Re: [11] RFR: Enhancement: JDK-8195811:Support FX Swing interop using public API

My Bad. Please find modified webrev restoring the filter http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.4/ Regards Prasanta On 7/6/2018 6:47 AM, Kevin Rushforth wrote: One quick comment: This no longer compiles with OpenJDK10. It looks like the logic to optionally filter out jdk.un

RE: [11] Review Request:JDK-8186187 Modify return type of public API StyleConverter.getEnumConverter()

Hi Kevin, Ajit Please review the updated patch with test case: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8186187/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/fx/8186187/webrev.01/ Regards, Prem From: Prem Balakrishnan Sent: Monday, May 14, 2018 5:04 PM To: Kevin Rushfo

Review Request Re: [PATCH] Fix bug to handle minus value glyph_id on Windows

Hi All. I created github account today and re-posted this patch to github. Please review the following fix: patch: https://github.com/javafxports/openjdk-jfx/pull/125 Regards, Akira Nakajima -- Company: NTT Comware Corporation Name: Akira Nakajima E-Mail: n

Re: [11] RFR: Enhancement: JDK-8195811:Support FX Swing interop using public API

One quick comment: This no longer compiles with OpenJDK10. It looks like the logic to optionally filter out jdk.unsupported.desktop from javafx.swing's module-info.java got lost between the .2 and .3 versions. -- Kevin On 7/4/2018 4:35 AM, Prasanta Sadhukhan wrote: Hi All, Please review a

Re: GitHub review for JDK-8203345: Memory leak in VirtualFlow when screen reader is enabled

Note that this has already been merged into the 'develop' branch on GitHub. Barring any objections, I'll push it to openjfx-dev tomorrow. On 7/5/2018 1:06 PM, Bernhard Lutzmann wrote: Hi, please review the following pull request on GitHub: JBS: https://bugs.openjdk.java.net/browse/JDK-8203345

RE: JavaFX 11 snapshots in maven sonatype

Hi Johan, Gradle doesn't ignore the classifier but there is no Windows- and Linux-version for the latest snapshot "20180702.224902-3". Gradle always checks for the latest snapshot, adds the classifier and tries to download this. The classifier 'mac' works with gradle. So all platform versions o

GitHub review for JDK-8203345: Memory leak in VirtualFlow when screen reader is enabled

Hi, please review the following pull request on GitHub: JBS: https://bugs.openjdk.java.net/browse/JDK-8203345 PR: https://github.com/javafxports/openjdk-jfx/pull/78 Thanks, Bernhard

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

I confirm my comments can be summarized as a "+1" - Johan On Thu, Jul 5, 2018 at 3:24 PM Kevin Rushforth wrote: > > > Kevin & Johan, do you consider the last webrev is approved by 2 > reviewers ? > > I took Johan's comment to be a "+1" from him. He can correct us if that > wasn't his intent. >

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

> Kevin & Johan, do you consider the last webrev is approved by 2 reviewers ? I took Johan's comment to be a "+1" from him. He can correct us if that wasn't his intent. -- Kevin On 7/5/2018 6:07 AM, Laurent Bourgès wrote: Johan, I agree Marlin 0.9.2 provides new clipping algorithms (cur

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

Johan, I agree Marlin 0.9.2 provides new clipping algorithms (curve subdivision & clipping in the dasher stage) so it involves lots of maths and tricks ... I implemented the automated ClipShapeTest that compares rendering with clipping enabled vs disabled for all possible combinations: - stroked &

Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2

I had a slightly deeper look and had a few comments, but it's hard to check the math behind it and evaluating performance without doing real tests. However, I feel confident we can merge it. That will also allow eager developers to use it and provide feedback. - Johan On Wed, Jul 4, 2018 at 9:55

JavaFX 11 snapshots in maven sonatype

A first batch of snapshots for the JavaFX 11 modules is now in the maven sonatype snapshot repository (see https://oss.sonatype.org/content/repositories/snapshots/org/openjfx/ although you probably don't want to work with these artifacts directly but use build tools like maven or gradle to do that)