Review-Request for JDK-8207377

2018-07-23 Thread Michael Ennen
Hi, I'd like to request a review for JDK-8207377 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/140 Thanks. -- Michael Ennen

Review-Request for JDK-8207370

2018-07-23 Thread Michael Ennen
Hi, I'd like to request a review for JDK-8207370 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/135 Thanks. -- Michael Ennen

Review-Request for JDK-8207794

2018-07-23 Thread Tom Schindl
Hi, I'd like to request a review for JDK-8207794 [1] available as a PR [2] on the Github-Mirror. Thanks Tom [1]https://bugs.openjdk.java.net/browse/JDK-8207794 [2]https://github.com/javafxports/openjdk-jfx/pull/139

Re: Simple Maven example fails with unusual error

2018-07-23 Thread Mark Raynsford
On 2018-07-23T17:22:34 +0200 Johan Vos wrote: > Hi Mark, > > So it seems these issues are not OpenJFX specific, and more projects will > run into this? > I'm a bit worried about the grey zone between OpenJDK and Maven/Gradle... > @Kevin are you aware of someone from the jigsaw team who is

Re: Simple Maven example fails with unusual error

2018-07-23 Thread Kevin Rushforth
Alan Bateman is probably the best person to ask about this, although I don't know how much he has looked into what maven is doing w.r.t. modules. The problem here seems to be that the dummy jar doesn't have a module-info.class, and so will become an automatic module with a name chosen based

Re: Simple Maven example fails with unusual error

2018-07-23 Thread Mark Raynsford
On 2018-07-23T10:49:29 +0100 Paul Ray Russell wrote: > Mark, > > I do find the following: > https://github.com/eclipse/jetty.project/issues/2397 - and I notice in your > POM you're using an annotation processor path. Removed that. Same error, unfortunately. I feel like we may be looking at

Re: Simple Maven example fails with unusual error

2018-07-23 Thread Mark Raynsford
On 2018-07-23T09:42:56 +0200 Johan Vos wrote: > Hi Mark, Paul, > > I can't reproduce the issue, as I'm running into these warnings that are > turned into errors, apparantly: > > [WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireProperty failed > with message: > Property

Re: Simple Maven example fails with unusual error

2018-07-23 Thread Johan Vos
Hi Mark, Paul, I can't reproduce the issue, as I'm running into these warnings that are turned into errors, apparantly: [WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireProperty failed with message: Property "io7m.api.previousVersion" evaluates to "". This does not match the regular