Review-Request for JDK-8209970

Hi, I'd like to request a review for JDK-8209970 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/168 https://bugs.openjdk.java.net/browse/JDK-8209970 Thanks. -- Michael Ennen

Re: building webkit

I think in the longrun using the adoptjdk approch is the one to follow. Tom Von meinem iPhone gesendet > Am 25.08.2018 um 19:01 schrieb Arunprasad Rajkumar > : > > As Kevin mentioned, I tried to make WebKit build work on Travis with few > hacks(using ccache). It seemed to be working, but not

Re: building webkit

Build time is kinda constant, with 2 cores, It would take around 1hr 15mins to complete. I need to restart the job several times to complete the incremental build with ccache doing some object file caching. > On 25-Aug-2018, at 10:47 PM, Johan Vos wrote: > > Is the non-consistency due to

Re: building webkit

Is the non-consistency due to varying build times, which may lead to canceled jobs? On Sat, Aug 25, 2018 at 7:12 PM Arunprasad Rajkumar < arunprasad.rajku...@oracle.com> wrote: > As Kevin mentioned, I tried to make WebKit build work on Travis with few > hacks(using ccache). It seemed to be

Re: building webkit

Using AdoptOpenJDK infrastructure would be great, but we're sort of stuck on Ansible. The AdoptOpenJDK build farm uses Ansible for provisioning systems with the required components. We're almost there with an Ansible script for Linux, but Windows turns out to be extremely complicated (at least for

Re: building webkit

As Kevin mentioned, I tried to make WebKit build work on Travis with few hacks(using ccache). It seemed to be working, but not consistently all the time. > How does AdoptJDK solve problems of long build times? Can we not adopt > their build chain/infrastructure? Looks like they host their own

IGNORE: [12] RFR: JDK-8209966: Update minimum boot JDK to 11

Please ignore this subject line. I re-sent the RFR with the correct subject line. There is not yet a proposed fix to review for updating the minimum boot JDK to 11 (nor will there be for another 3-4 weeks until JDK 11 is released). Sorry for the mix-up. -- Kevin

[12] RFR: 8209967: Bump minimum gradle version to 4.8 for JDK 11

[resend with the correct subject line] On 8/25/2018 8:18 AM, Kevin Rushforth wrote: Please review the following on GitHub: https://bugs.openjdk.java.net/browse/JDK-8209967 https://github.com/javafxports/openjdk-jfx/pull/169 This bumps the minimum version of gradle for openjfx 12 to the

[12] RFR: JDK-8209966: Update minimum boot JDK to 11

Please review the following on GitHub: https://bugs.openjdk.java.net/browse/JDK-8209967 https://github.com/javafxports/openjdk-jfx/pull/169 This bumps the minimum version of gradle for openjfx 12 to the current 4.8 version (which is the version used by our builds and by gradlew). This is

Re: building webkit

Hi, How does AdoptJDK solve problems of long build times? Can we not adopt their build chain/infrastructure? Tom On 25.08.18 15:00, Kevin Rushforth wrote: > Yes, this should be possible to do. Even without build changes, we could > build just the SDK + WebKit (and maybe media, too, or maybe a

Re: Build fails at graphics:linkWinFont

Good to know. -- Kevin On 8/25/2018 12:47 AM, John Hendrikx wrote: There should have been a gdi32.lib in the x64 folder as well, but there wasn't.  Downloading a Windows SDK (10.0.16299) and installing it solved this. --John On 25/08/2018 00:24, Kevin Rushforth wrote: C:/Program Files

Re: building webkit

Yes, this should be possible to do. Even without build changes, we could build just the SDK + WebKit (and maybe media, too, or maybe a separate job for that). The problem is that even building just WebKit takes longer than Travis / Appveyor will allow. See PR #121 [1]. Arun can comment

Re: Build fails at graphics:linkWinFont

There should have been a gdi32.lib in the x64 folder as well, but there wasn't. Downloading a Windows SDK (10.0.16299) and installing it solved this. --John On 25/08/2018 00:24, Kevin Rushforth wrote: C:/Program Files (x86)/Windows Kits/10/lib/10.0.16299.0/um/x86\gdi32.lib : warning

building webkit

We currently don't build WebKit with Appveyor/Travis, as the combined build time would be too long. I'm wondering though if it would be possible to have separate build jobs for webkit? Typically, when building a JavaFX SDK, the webkit part is where things go wrong (if they go wrong), and have

[RFR] [openjfx12] 8148129: Implement Accelerated composition for WebView

Hi, Please review the patch for following enhancement, it is targeted for openjfx12. https://bugs.openjdk.java.net/browse/JDK-8148129 Changes are available as gihub PR, refer the following link, https://github.com/javafxports/openjdk-jfx/pull/51 Unified diff is available in the following