Review request for JDK-8207839, JDK-8207932, JDK-8208076 (variation selector)

2018-11-13 Thread Nakajima Akira
Hi Kevin, Phil, Please review the following Github PR. JDK-8207839 https://github.com/javafxports/openjdk-jfx/pull/125 https://github.com/javafxports/openjdk-jfx/pull/125/files JDK-8207932 https://github.com/javafxports/openjdk-jfx/pull/126

[RFR][openjfx12] JDK-8211307: Add prefix to build tools paths

2018-11-13 Thread Arunprasad Rajkumar
Hi, Please review the following Github PR, https://github.com/javafxports/openjdk-jfx/pull/283 https://bugs.openjdk.java.net/browse/JDK-8211307 Thanks, Arun

Re: Bug: Not on FX application thread exception is inconsistent

2018-11-13 Thread Tom Eugelink
This isn't me not doing my research, this is objectively JavaFX not providing the functionality that is necessary to do something rather trivial: update an API object and provide information from that API object right after it's updated to the user(without ChangeListener). You are not

Re: Bug: Not on FX application thread exception is inconsistent

2018-11-13 Thread Mario Torre
Il giorno mar 13 nov 2018 alle ore 16:11 Ty Young ha scritto: > > > On 11/12/18 9:12 PM, Brian Hudson wrote: > > JavaFX like every other modern UI framework is single threaded. > > > Which in itself is fine, running *just* the UI isn't much on modern > processors. Adding a bunch of API object

Re: Bug: Not on FX application thread exception is inconsistent

2018-11-13 Thread Ty Young
On 11/13/18 12:12 AM, Tom Schindl wrote: I'm sorry that I'm the one to bring you the bad news that you need to do the work and can't offload multi-threading to JavaFX. I already explain why it *seems* to work one some elements (until it breaks like shown in the bug-report I referenced) and

Re: Classes seem to be too restrictive

2018-11-13 Thread Nir Lisker
Hi, it is imposible to write an own ResizePolicy for tables Is TableView#setColumnResizePolicy not good enough? [1] https://openjfx.io/javadoc/11/javafx.controls/javafx/scene/control/TableView.html#setColumnResizePolicy(javafx.util.Callback) - Nir On Tue, Nov 13, 2018 at 10:32 AM Thimo von

Review request for JDK-8213541

2018-11-13 Thread Sam'
If anyone wants to review my PR for https://bugs.openjdk.java.net/browse/JDK-8213541 , it would be valuable. PR can be seen here : https://github.com/javafxports/openjdk-jfx/pull/281