Re: Javapackager 10 to bundle OpenJDK 11 runtime

2018-12-19 Thread Johan Vos
The packager that works with Java 11 and JavaFX 11 is at http://download2.gluonhq.com/jpackager/11/jdk.packager-linux.ziphttp://download2.gluonhq.com/jpackager/11/jdk.packager-osx.ziphttp://download2.gluonhq.com/jpackager/11/jdk.packager-windows.zip (see

RE: RFR: 8214119: Update to 607.1 version of WebKit

2018-12-19 Thread Murali Billa
Looks fine. +1 One minor observation: WCFontImpl.java -> Regarding log.fine(String.format("str='%s' length=%d", str, str.length()));, I see earlier code which followed below format for ‘length’ log.fine(String.format("str='%s' (length=%d)", str, str.length())); Thanks, Murali

Re: Javapackager 10 to bundle OpenJDK 11 runtime

2018-12-19 Thread Alan White (Drum Score Editor)
Thanks. I’ll grab the Glueon ones for now to finish the app migration to 11, ie get off jdk 8 before January, and start working with the EA jpackager and migrate when suitable. Alan > On 19 Dec 2018, at 13:51, Kevin Rushforth wrote: > > I doubt that will work. > > We are developing a

Re: RFR: 8214119: Update to 607.1 version of WebKit

2018-12-19 Thread Kevin Rushforth
Looks good to me. +1 -- Kevin On 12/18/2018 10:16 AM, Arunprasad Rajkumar wrote: Hi Kevin, Murali, Johan, Joeri, Please review the following patch which merges GTK WebKit 2.22(607.1) into jfx-dev: http://cr.openjdk.java.net/~arajkumar/8214119/webrev Above link has a webrev and a changeset

Javapackager 10 to bundle OpenJDK 11 runtime

2018-12-19 Thread Alan White (Drum Score Editor)
I understand the guidance for apps created with OpenJDK 11, is to use the javapackager from jdk 10. The old basedir parameter that could be used to direct the packager to use a specific runtime is no longer present. Is there any mechanism I’ve missed in order to have the packager from jdk10

Re: Q: Rotated labels, layout and reflow

2018-12-19 Thread Tom Eugelink
Hey John, Is VerticalLabel implementation good enough to add to any of the open source projects? Tom On 19-12-2018 09:55, John Hendrikx wrote: Update. I did an attempt to add this functionally to Label itself, by editing LabeledSkinBase, and with a few minor modifications (mainly swapping

Review-Request for JDK-8215629

2018-12-19 Thread Michael Ennen
Hi, I'd like to request a review for JDK-8209970 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/328 https://bugs.openjdk.java.net/browse/JDK-8215629 Thanks.