Re: Previews for shared buffer PR

2019-07-05 Thread Ty Young
On 6/7/19 4:40 AM, Johan Vos wrote: The PR discussed in https://github.com/javafxports/openjdk-jfx/pull/472, addressing https://bugs.openjdk.java.net/browse/JDK-8167148 provides a very much wanted feature. It is important that things are done in the right way so that the code can be

RFR: 8185937 - Spinner with Double/Integer value factory ignores up/down arrow keys

2019-07-05 Thread Scott Palmer
Please review the fix for JDK-8185937 - Spinner with Double/Integer value factory ignores up/down arrow keys https://bugs.openjdk.java.net/browse/JDK-8185937 https://github.com/javafxports/openjdk-jfx/pull/517

Re: Windows (32bit) build problems

2019-07-05 Thread Michael Ennen
I recommend using https://github.com/javafxports/openjdk-jfx/blob/develop/tools/scripts/build.ps1 when trying to build OpenJFX locally on Windows. I personally use it with the "-nocygwin" argument so that it does not try and auto-install cygwin. On Fri, Jul 5, 2019 at 5:31 AM Robert Lichtenberger

Re: Windows (32bit) build problems

2019-07-05 Thread Dan Howard
You will need Windows 7 or later (Windows 10 is recommended) 64-bit OS On 7/4/2019 11:01 AM, Robert Lichtenberger wrote: Hello everyone, I try to build JavaFX-12 mods for Windows-32. For that I cloned http://hg.openjdk.java.net/openjfx/12-dev/rt/ (correct?) and read the build instructions at

Re: Windows (32bit) build problems

2019-07-05 Thread Robert Lichtenberger
I've started from scratch and one obvious problem in win.gradle is this line: > > defineProperty("WINDOWS_VS_VSINSTALLDIR", properties, "c:/Program > Files (x86)/Microsoft Visual Studio/2017/Professional"); as it hardcodes the Professional version of VS. I've also found [1] which