Re: [Rev 01] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

On Tue, 5 Nov 2019 15:43:03 GMT, Jeanette Winzenburg wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 0366a0a5: added copyright header > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/20/files > - new:

RFR: 8130738: TextFlow's tab width is static

Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to both. TextFlow's tab size overrides that of contained Text nodes. Commits: - 68d221c7: 8130738: TextFlow's tab width is static Changes: https://git.openjdk.java.net/jfx/pull/32/files Webrev:

FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

Using a script engine (javax.script.ScriptEngine) for implementing a FXML controller there are two important information missing in the ScriptContext.ENGINE_SCOPE Bindings supplied to the script used to eval() the script code: * ScriptEngine.FILENAME o This value denotes the file name

Re: [Rev 01] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

The pull request has been updated with additional changes. Added commits: - a1cdb37b: Removed whitespaces in @Deprecated comments Changes: - all: https://git.openjdk.java.net/jfx/pull/30/files - new: https://git.openjdk.java.net/jfx/pull/30/files/6d29e034..a1cdb37b

Re: JDK-8130738 TextFlow's tab width is static

Hi Scott, The CSS reference is here: modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html As for your question about indentation, reformatting entire files or large blocks of code you aren't touching is discouraged. In your specific case, reformatting the methods in the

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: > On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg wrote: > >> On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushforth wrote: >>> On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker

Re: [Integrated] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

Changeset: 286d1b54 Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-11-06 12:43:43 + URL: https://git.openjdk.java.net/jfx/commit/286d1b54 8230492: font-family not set in HTMLEditor if font name has a number in it Reviewed-by: kcr, shadzic !

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg wrote: > On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushforth wrote: >> >>> On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: >>> https://bugs.openjdk.java.net/browse/JDK-8229472

RFR: 8231188: Update SQLite to version 3.30.1

We currently use SQLite version 3.28.0. We should update to the latest stable release version 3.30.1 released. https://www.sqlite.org/index.html Commits: - 24c6375d: 8231188: Update SQLite to version 3.30.1 Changes: https://git.openjdk.java.net/jfx/pull/31/files Webrev:

Re: [Rev 01] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

On Tue, 5 Nov 2019 11:17:55 GMT, Arun Joseph wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - afc7f17a: Minor formatting > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/27/files > - new:

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier wrote: > Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 > > A side effect of JDK-8200224 is, that the first click on a JFXPanel is always > a double click. > The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on