Re: [Approved] RFR: 8211308: Support HTTP/2 in WebView

2019-11-28 Thread Guru Hb
On Wed, 16 Oct 2019 17:57:58 GMT, Arunprasad Rajkumar wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 1832c2db: Incorporate fixes provided by @kcr > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/14/files > -

Re: RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-11-28 Thread Arun Joseph
On Wed, 20 Nov 2019 15:04:07 GMT, Kevin Rushforth wrote: > On Wed, 20 Nov 2019 07:05:40 GMT, Arun Joseph wrote: > >> Issue: Native part of WebView throws a DOMException and then, continues >> executing the rest of the function assuming that value is present. This >> causes the JVM to crash

Re: [Rev 01] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-11-28 Thread Arun Joseph
The pull request has been updated with additional changes. Added commits: - 2bd56c11: Modified only raiseOnDOMError Changes: - all: https://git.openjdk.java.net/jfx/pull/47/files - new: https://git.openjdk.java.net/jfx/pull/47/files/acc52780..2bd56c11 Webrevs: - full:

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-28 Thread Arunprasad Rajkumar
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified

Re: [Approved] RFR: 8232064: Switch FX build to use JDK 13.0.1 as boot JDK

2019-11-28 Thread Johan Vos
On Fri, 22 Nov 2019 21:13:05 GMT, Kevin Rushforth wrote: > Now that we have switched to using gradle 6 we can switch to using JDK 13 as > the boot JDK for JavaFX 14 builds. The latest JDK 13 update release is JDK > 13.0.1. > > This will not change the minimum JDK version needed to build or

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-28 Thread Ambarish Rapte
On Wed, 27 Nov 2019 21:13:40 GMT, Johan Vos wrote: > On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > >> Memory allocated in initDecompressor() and decompressIndirect() is not freed >> in error case. >> In error case, >> 1. Allocated memory should be freed. >> 2. Appropriate