On Wed, 11 Dec 2019 18:43:23 GMT, Kevin Rushforth wrote:
>> I don't get an assertion error on Oracle Linux 7.7 -- so far only on Ubuntu
>> 16.04. I will resume reviewing once you restore the `DRAG_DONE` behavior.
>
> With your latest patch, which reverts the changes to `GtkDnDClipboard.java`,
On Wed, 11 Dec 2019 00:21:20 GMT, Kevin Rushforth wrote:
>>> Does it send the event on other platforms? I can test on Windows.
>>
>> Yes, it always sends the `DRAG_DONE` event on all platforms today (I tested
>> it on Mac, Windows, and Linux).
>>
>>> Will look into the assertion error - it
> On Dec 10, 2019, at 8:23 PM, Kevin Rushforth wrote:
...
>
> I think a new `TextFlowTest.java` would be a good place for those tests.
My first attempt at unit tests for TextFlow are failing. I believe the
StubTextLayout is not equipped to handle TextFlow. This may be a bigger job…
This
On Tue, 10 Dec 2019 16:27:10 GMT, Kevin Rushforth wrote:
>> Issue: NPE in GlassScene.frameRendered().
>>
>> Cause: scenePaintListener is set in setTKScenePaintListener(), used in
>> frameRendered() and
>> set to null in dispose().
>> setTKScenePaintListener() and dispose() are called on
On Wed, 11 Dec 2019 16:23:49 GMT, Nir Lisker wrote:
>> This will need two reviewers.
>
> Isn't Pisces going to be completely removed anyway?
The Pisces rasterizer will be removed, but as it turns out, the two classes in
question are used by the prism-sw pipeline as part of the Pisces-based
On Wed, 11 Dec 2019 16:06:48 GMT, Kevin Rushforth wrote:
>> The finalize() method is deprecated in JDK9. See [Java 9 deprecated
>> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html).
>> And so the
>>
On Wed, 11 Dec 2019 15:41:38 GMT, Ambarish Rapte wrote:
> The finalize() method is deprecated in JDK9. See [Java 9 deprecated
> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html).
> And so the
>
The finalize() method is deprecated in JDK9. See [Java 9 deprecated
features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html).
And so the
On Wed, 11 Dec 2019 12:34:51 GMT, Jeanette Winzenburg
wrote:
>> just to let you know: locally added test to explicitly guard against
>> JDK-8145515 (and an ignored one for the regression JDK-8229914) - they are
>> passing/failing the same before/after this fix. Will push later ...
>
> pushed
On Tue, 10 Dec 2019 14:02:23 GMT, Jeanette Winzenburg
wrote:
>> no don't think so: the fix for JDK-8145515 was to prevent the triggering of
>> parent.fireEvent, so removing the method altogether should have no effect :)
>> Could add a test to explicitly guard against this.
>>
>> Please note
> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>
> The issue is that default/cancel button on a scene are triggered even though
> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
> for details on both cause and fix.
>
> There are
11 matches
Mail list logo
