Linux Glass - WindowContextChild and WindowContextPlug

2019-12-31 Thread Thiago Milczarek Sayao
Does anyone knows the context of use of WindowContextChild and WindowContextPlug on the linux glass implementation? File: glass_window.cpp They seem to be never called. Thanks.

Re: [Rev 06] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-31 Thread Kevin Rushforth
On Tue, 31 Dec 2019 18:19:29 GMT, Scott Palmer wrote: >> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute >> to both. TextFlow's tab size overrides that of contained Text nodes. > > The pull request has been updated with 1 additional commit. Looks good now.

Re: error in tutorial

2019-12-31 Thread Kevin Rushforth
Ignoring jmods for a moment, since those are only intended to be used by jlink to produce an image that includes the modules (jmods are not a runtime format)... The issue being caused by the src.zip in the lib directory of the JavaFX SDK seems more like a problem with the IDE(s) in question

Should Skara tooling invalidate approvals when new commits are pushed? [was: RFR: 8130738: Add tabSize property to Text and TextFlow]

2019-12-31 Thread Kevin Rushforth
Since this isn't directly related to the PR in question, I'm starting a new thread. On 12/20/2019 7:22 PM, Philip Race wrote: On 12/20/19, 7:04 PM, Scott Palmer wrote: I'm not sure if I'me supposed to try to integrate now that I've made that 10 ->  0 change, or if the new change resets the

Re: RFR: 8236484: Compile error in monocle dispman

2019-12-31 Thread Kevin Rushforth
On Sat, 21 Dec 2019 18:10:37 GMT, Johan Vos wrote: > Trivial fix for a compiler error where a void function returns a long - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/74

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-31 Thread Kevin Rushforth
On Sat, 21 Dec 2019 20:35:10 GMT, Phil Race wrote: >> Link problem appears to just be a missing slash: >> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md > >> Link problem appears to just be a missing slash: >> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md > > Seems