Re: [Integrated] RFR: 8236808: javafx_iio can not be used in static environment

2020-01-08 Thread Johan Vos
Changeset: f9070263 Author:Johan Vos Date: 2020-01-09 07:16:52 + URL: https://git.openjdk.java.net/jfx/commit/f9070263 8236808: javafx_iio can not be used in static environment Reviewed-by: kcr ! modules/javafx.graphics/src/main/native-iio/jpegloader.c

RFR: 8236733: Change JavaFX release version to 15

2020-01-08 Thread Kevin Rushforth
JDK-8236733](https://bugs.openjdk.java.net/browse/JDK-8236733). Bump the release version to 15. As noted in the JBS issue, I will wait until right after the `jfx14` fork to integrate this. - Commits: - 50f38ab6: 8236733: Change JavaFX release version to 15 Changes:

Re: RFR: 8236733: Change JavaFX release version to 15

2020-01-08 Thread Kevin Rushforth
On Thu, 9 Jan 2020 02:39:09 GMT, Kevin Rushforth wrote: > JDK-8236733](https://bugs.openjdk.java.net/browse/JDK-8236733). > > Bump the release version to 15. As noted in the JBS issue, I will wait until > right after the `jfx14` fork to integrate this. Reviewer: @arapte - PR:

Re: [Rev 06] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-08 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

RFR: 8236753: Animations do not play backwards after being stopped

2020-01-08 Thread Nir Lisker
The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling

RFR: 8236808: javafx_iio can not be used in static environment

2020-01-08 Thread Johan Vos
The static JNI_OnLoad naming should be used whenever we are building a static lib (not only for iOS). We now have the STATIC_BUILD property to determine if we are making a static build, so we no longer need to check on ios specific patterns. Fix JDK-8236808 - Commits: - 54c14bb8:

Re: Should Skara tooling invalidate approvals when new commits are pushed? [was: RFR: 8130738: Add tabSize property to Text and TextFlow]

2020-01-08 Thread Nir Lisker
Looks like an all-or-nothing situation - either any commit requires re-approval or no commit requires re-approval. In this case, I would say that all commits should require re-approval since it's the safer approach. Having the issue stay in approved state after a significant change is much worse

Re: Skara - bot sending can-be-integrated message prematurely?

2020-01-08 Thread Nir Lisker
I forgot to mention that I filed these: https://bugs.openjdk.java.net/browse/SKARA-218 https://bugs.openjdk.java.net/browse/SKARA-217 They weren't triaged, so maybe the Skara team needs to be notified. On Thu, Dec 19, 2019 at 6:24 PM Kevin Rushforth wrote: > FYI, for anyone interested, the

Re: OpenJFX is not using FontConfig

2020-01-08 Thread Philip Race
Perhaps you could trace the process to see if we successfully load the shared library ? Maybe we can't do that or can't initialise it for some reason. But Centos 7.4 is the same as RH 7.4 and OL 7.4 so this is surprising. Do you have the same fontconfig packages on working and non-working ?

OpenJFX is not using FontConfig

2020-01-08 Thread Fabian Keller
Hi, I'm currently investigating a problem where openjfx is not using FontConfig on a CentOS machine. Error message: ... Loading FontFactory com.sun.javafx.font.freetype.FTFactory Subpixel: enabled Freetype2 Loaded (version 2.8.0) LCD support Disabled Fallback fontDir is

Re: [Integrated] RFR: 8236448: Remove unused and repair broken Android/Dalvik code

2020-01-08 Thread Johan Vos
Changeset: e6587ff0 Author:Johan Vos Date: 2020-01-08 14:20:28 + URL: https://git.openjdk.java.net/jfx/commit/e6587ff0 8236448: Remove unused and repair broken Android/Dalvik code Reviewed-by: kcr ! buildSrc/android.gradle !

Re: Proposed schedule for JavaFX 14

2020-01-08 Thread Kevin Rushforth
Are you asking how to tell whether a PR is targeted for JavaFX 14 or 15 after the RDP1 fork? I'll send out details on Friday morning after the fork, but it's effectively the same as it's been for the last several releases. The 'master' branch of jfx is always where the current development