Changeset: 21d3b7e0
Author:Ambarish Rapte
Date: 2020-02-07 05:59:01 +
URL: https://git.openjdk.java.net/jfx/commit/21d3b7e0
8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering
Reviewed-by: kcr, aghaisas
!
On Wed, 5 Feb 2020 11:07:39 GMT, Ambarish Rapte wrote:
> Issue:
> Dragging a tab and dropping it back to it's original position causes an
> incorrect reordering of tabs. Incorrect order of tabs can be observed using
> arrow key traversal through tabs.
>
> Cause:
> Below mechanism of
Changeset: e224e549
Author:Guru Hb
Date: 2020-02-07 02:13:15 +
URL: https://git.openjdk.java.net/jfx/commit/e224e549
8238526: Cherry pick GTK WebKit 2.26.3 changes
Reviewed-by: kcr, jvos
!
On Thu, 6 Feb 2020 09:22:56 GMT, Guru Hb wrote:
> Fix contains https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html
Marked as reviewed by jvos (Reviewer).
-
PR: https://git.openjdk.java.net/jfx/pull/107
On Thu, 6 Feb 2020 19:35:18 GMT, Kevin Rushforth wrote:
>> Marked as reviewed by kcr (Lead).
>
> As part of the review, I did a sanity build / test on all three platforms.
> All looks good.
build and basic checks ok on mac/linux/win64. Didn't test on win32.
-
PR:
On Thu, 6 Feb 2020 19:31:25 GMT, Kevin Rushforth wrote:
>> Fix contains https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html
>
> Marked as reviewed by kcr (Lead).
As part of the review, I did a sanity build / test on all three platforms. All
looks good.
-
PR:
On Thu, 6 Feb 2020 09:22:56 GMT, Guru Hb wrote:
> Fix contains https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/107
Great, thanks Danny, I’ll check it out and let you know how it goes
From: Danny Gonzalez
Date: Thursday, 6 February 2020 at 17:27
To: Ed Kennard
Cc: "openjfx-dev@openjdk.java.net"
Subject: Re: TableView with many columns poor ui performance
Hi Ed,
I have submitted a pull request and the
Hi Ed,
I have submitted a pull request and the branch is here:
https://github.com/screamingfrog/jfx/tree/listeners_optimisation
Danny
On 6 Feb 2020, at 09:50, Ed Kennard mailto:e...@kennard.net>>
wrote:
Hi Danny,
This is great news, I've previously written about perf issues with
On Thu, 6 Feb 2020 16:05:59 GMT, Johan Kaving
wrote:
>> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that
>> we leave the
>> current system menubar alone when other menubars are changed.
>>
>> It also adds a test case that reproduces the problem before the fix.
>
>
On Wed, 5 Feb 2020 19:15:23 GMT, Kevin Rushforth wrote:
>> Previous commits in this pull request have been removed, probably due to a
>> force push. The incremental views will show differences compared to the
>> previous content of the PR.
>
>
On Thu, 6 Feb 2020 13:18:00 GMT, Johan Kaving
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/MenuBarSkinTest.java
>> line 33:
>>
>>> 32: import com.sun.javafx.stage.WindowHelper;
>>> 33: import javafx.scene.control.MenuItem;
>>> 34: import
On Thu, 6 Feb 2020 13:23:54 GMT, Johan Kaving
wrote:
>> Of, course - I've added a commit that moves the import statement.
>
>> I just realised that I did not make the commit with the same email address
>> that I used on the OCA (but both addresses are linked to my GitHub account).
>
> And I
> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that
> we leave the
> current system menubar alone when other menubars are changed.
>
> It also adds a test case that reproduces the problem before the fix.
Previous commits in this pull request have been removed, probably
> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that
> we leave the
> current system menubar alone when other menubars are changed.
>
> It also adds a test case that reproduces the problem before the fix.
The pull request has been updated with 1 additional commit.
Changeset: 6968e38d
Author:Dean Wookey
Committer: Kevin Rushforth
Date: 2020-02-06 13:16:16 +
URL: https://git.openjdk.java.net/jfx/commit/6968e38d
8237469: Inherited styles don't update when node is moved
Reviewed-by: dgrieve, aghaisas, kcr
!
Hi Danny,
This is great news, I've previously written about perf issues with TableView,
do you have a branch I could try out which is rebased off current jfx master?
On 06/02/2020, 10:40, "openjfx-dev on behalf of Danny Gonzalez"
wrote:
Hi,
We have been struggling with our
Hi,
We have been struggling with our migration from Java 8 to Java 11 due to
various issues we are having with TableView. The main issue is the general UI
lag and slow TableView scroll performance.
For context here some links around the issues:
TableView has a horrific performance with many
Fix contains https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html
-
Commits:
- 025373db: 8238526: Cherry pick GTK WebKit 2.26.3 changes
Changes: https://git.openjdk.java.net/jfx/pull/107/files
Webrev: https://webrevs.openjdk.java.net/jfx/107/webrev.00
Issue:
19 matches
Mail list logo
