Re: [jfx14] [Rev 01] RFR: 8228867: Fix mistakes in FX API docs

2020-02-17 Thread Nir Lisker
> Docs fixes for OpenJFX 14. We can wait with integrating this in case there > are last minute fixes, but reviews can start. The pull request has been updated with 2 additional commits. - Added commits: - 75d34b85: Update copyright year - 131850d2: Fix extra } Changes: - all:

Monocle as a replacement

2020-02-17 Thread Tres Finocchiaro
Hi, I'm the developer of a printing plugin which leverages JavaFX for a few HTML functions. One of our functions would greatly benefit from being "headless (or more accurately, "silent") mode that Monocle offers and I'm evaluating the use of Monocle on (non-headless) Desktops for this. I'm

AssertionError in ScheduledService.executeTask

2020-02-17 Thread Sebastian Stenzel
When restart()ing a ScheduledService while having assertions enabled, the assertions in [1] or [2] fail. Without assertions the code seems to run fine, though. According to the inline comments, "resetting things should have cleared the delayTask". Therefore I wonder, if resetting the delayTask

Re: Question ad creating a testcase that needs a jar on class- or module path

2020-02-17 Thread Kevin Rushforth
Replies inline. On 2/17/2020 7:40 AM, Rony G. Flatscher wrote: Over the weekend I was finally able to finalize the test unit in form of a module. Kept it as simple as possible (but it includes a pseudo script engine). May I just ask a few questions, before proceeding with submitting one or

Re: Question ad creating a testcase that needs a jar on class- or module path

2020-02-17 Thread Rony G. Flatscher
Over the weekend I was finally able to finalize the test unit in form of a module. Kept it as simple as possible (but it includes a pseudo script engine). May I just ask a few questions, before proceeding with submitting one or two PRs: * Every new program needs the Oracle license header at

Re: RFR: 8238434: Ensemble: Update version of Lucene to 7.7.2

2020-02-17 Thread Ajit Ghaisas
On Tue, 4 Feb 2020 22:41:37 GMT, Kevin Rushforth wrote: >> @aghaisas can you review this? > > I pushed a new commit that reverts the changes to the stored binary index > files. There is no need to regenerate them when upgrading to a new version > where only the `bugfix` number (the third

Re: [Rev 01] RFR: 8238434: Ensemble: Update version of Lucene to 7.7.2

2020-02-17 Thread Ajit Ghaisas
On Tue, 4 Feb 2020 22:47:18 GMT, Kevin Rushforth wrote: >> Update the version of Lucene used by Ensemble to the latest release of >> Lucene 7 which is version 7.7.2. >> >> Per the instructions in >>