RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

https://bugs.openjdk.java.net/browse/JDK-8236832 - This issue most likely caused by changes in AVFoundation APIs on macOS 10.15. - Getting currentTime from AVPlayer was blocked if it is done from ProcessAudioTap callback (used for spectrum, equalizer and volume) on first call. If we reading

Re: [Integrated] RFR: 8238755: allow to create static lib for javafx.media on linux

Changeset: ef2f9ce9 Author:Johan Vos Date: 2020-02-25 22:02:00 + URL: https://git.openjdk.java.net/jfx/commit/ef2f9ce9 8238755: allow to create static lib for javafx.media on linux Reviewed-by: kcr, almatvee !

Re: PixelBuffer API threading model?

Am 25.02.20 um 15:51 schrieb Neil C Smith: In there, we have a small amount of locking between the GStreamer callback and the OpenGL thread to cover buffer swap and texture upload. Being able to do likewise with the PixelBuffer API, to swap or null the underlying buffer, would cover both use

Re: [Rev 01] RFR: 8237889: Update libxml2 to version 2.9.10

On Fri, 21 Feb 2020 20:25:30 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > Looks good. I did a full build / test on Windows, and a full build on Mac and > Linux. @johanvos or @tiainen can one of you be the second reviewer? This isn't urgent,

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

On Tue, 25 Feb 2020 18:15:31 GMT, Bernhard M. Wiedemann wrote: >>> FWIW, I have scripts that will unpack the modular jar files and diff each >>> class >> >> I agree that such specialized diff tools have some value, yet, there are >> also some limitations and downsides to them. E.g. you

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

On Sat, 8 Feb 2020 11:14:29 GMT, Bernhard M. Wiedemann wrote: >> As an optional override, I am OK with the concept of having a way for the >> build to be reproducible. >> >> FWIW, I have scripts that will unpack the modular jar files and diff each >> class as well as doing the same for a

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Mon, 24 Feb 2020 17:15:02 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 >> >> Fix : Added the missed out RTL checks to the key mappings in >> TableViewBehaviorBase class. >> >> Testing : Modified unit tests in TableViewKeyInputTest to take orientation

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Tue, 25 Feb 2020 15:04:05 GMT, Jeanette Winzenburg wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java > line 1141: > >> 1140:

Re: PixelBuffer API threading model?

Hi, On Tue, 25 Feb 2020 at 13:25, Kevin Rushforth wrote: > This points out a flaw in the specification. ... > To answer your other question about adding an API to PixelBuffer to swap > out the underlying Buffer (to avoid yet another copy), I'm not sure how > hard that would be (we currently

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 25 Feb 2020 13:55:50 GMT, Nir Lisker wrote: >> Replying to @nlisker and @kevinrushforth general comments about the memory >> consumption of using a LinkedHashMap: >> >> I agree that at the very least these should be lazy initialised when they >> are needed and that we should initially

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

On Tue, 25 Feb 2020 11:51:09 GMT, Ajit Ghaisas wrote: >> The pull request has been updated with 1 additional commit. > > Marked as reviewed by aghaisas (Reviewer). > Looks good to me. Just the dates in the copyright headers need to be updated. They will get updated when I update copyrights of

Re: [Integrated] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

Changeset: c3ee1a30 Author:Kevin Rushforth Date: 2020-02-25 14:01:57 + URL: https://git.openjdk.java.net/jfx/commit/c3ee1a30 8239822: Intermittent unit test failures in RegionCSSTest Reviewed-by: aghaisas !

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 25 Feb 2020 12:18:34 GMT, dannygonzalez wrote: >> I haven't done a detailed review yet, but I worry about the memory >> consumption and performance of using a Map for the simple cases where there >> is only a single (or very small number) of listeners. These methods are used >> in

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

On Sun, 23 Feb 2020 14:57:44 GMT, Rony G. Flatscher wrote: >> OK, forgot to submit an explanatory text related to this fix. Posted [1] >> which explains the problem and the suggested solution for discussion. >> >> - This pull request relates to: >>

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

On Sun, 23 Feb 2020 14:54:32 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > OK, forgot to submit an explanatory text related to this fix. Posted [1] > which explains the problem and the suggested solution for discussion. >

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

On Sat, 22 Feb 2020 15:39:35 GMT, Rony G. Flatscher wrote: > …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV OK, forgot to submit an explanatory text related to this fix. Posted [1] which explains the problem and the suggested solution for discussion. - This

RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

…9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV - Commits: - 30539592: Removed/replaced white space. - 5c33d590: fix for JDK-8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME

Re: PixelBuffer API threading model?

Hi Neil, I didn't look at your use case in detail, so I missed that you were talking about freeing the native memory that is backing your DirectBuffer. No, freeing the memory immediately after calling setImage(null) will not work. The JavaFX rendering is done in a different thread, which

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 25 Feb 2020 00:43:34 GMT, Kevin Rushforth wrote: >> Sorry for the interruption, send a PR that corrects the same problem. > > I haven't done a detailed review yet, but I worry about the memory > consumption and performance of using a Map for the simple cases where there > is only a

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >>

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 25 Feb 2020 00:45:06 GMT, Kevin Rushforth wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/binding/ExpressionHelper.java >> line 194: >> >>> 193: private Map >>> invalidationListeners = new LinkedHashMap<>(); >>> 194: private Map, Integer> >>>

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >>

Re: PixelBuffer API threading model?

On Fri, 21 Feb 2020 at 12:39, Kevin Rushforth wrote: > I missed seeing this yesterday. Since you have a test program, can you > file a bug at: > > https://bugreport.java.com/ > > and include your test case? Thanks Kevin. I need to replicate without a particular dependency, but will do ASAP.