Here is a WIP [1] implementation of [2]. The WIP is based on [3], which is
currently in review, and
has an appropriate test unit going with it as well, please review.
There should be no compatibility issue with this implementation.
Discussion: another solution could be to not compile by
On Wed, 12 Feb 2020 14:57:33 GMT, Frederic Thevenet
wrote:
>> Issue JDK-8088198, where an exception would be thrown when trying to capture
>> a snapshot whose final dimensions would be larger than the running
>> platform's maximum supported texture size, was addressed in openjfx14.
>> The
Issue JDK-8088198, where an exception would be thrown when trying to capture a
snapshot whose final dimensions would be larger than the running platform's
maximum supported texture size, was addressed in openjfx14.
The fix, based around the idea of capturing as many tiles of the maximum
On Wed, 12 Feb 2020 13:21:03 GMT, Frederic Thevenet
wrote:
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be larger than the running platform's
> maximum supported texture size, was addressed in openjfx14.
> The fix,
On Fri, 28 Feb 2020 12:14:24 GMT, Ajit Ghaisas wrote:
>> Initially I had thought about adding separate test file for RTL - something
>> like RTLTableViewKeyInputTest - but, realized that although it's a cleaner
>> approach, we would simply duplicate the tests. Also, the fact is only
>>
On Fri, 28 Feb 2020 17:22:39 GMT, Jeanette Winzenburg
wrote:
>> Regarding your suggestion of having forward/backward semantic methods and
>> calling them in tests -
>> There are two types of tests -
>> 1. Key action remains same - asserts differ based on NodeOrientation
>> 2. Key action
On Fri, 28 Feb 2020 16:06:43 GMT, Johan Vos wrote:
>> The pull request has been updated with 1 additional commit.
>
> Build + sanity tests are ok on win/mac/linux
This looks ok. I suggest to merge it sooner rather than later, so that we can
create an EA built that has this code and have it
Changeset: 20328b38
Author:Johan Vos
Date: 2020-02-28 16:20:49 +
URL: https://git.openjdk.java.net/jfx/commit/20328b38
8240218: IOS Webkit implementation broken
Reviewed-by: kcr
+ modules/javafx.web/src/ios/java/com/sun/java/scene/web/WebViewHelper.java
!
On Fri, 28 Feb 2020 15:46:12 GMT, Johan Vos wrote:
>> Make modifications to javafx.web files for iOS, so that it can compile again.
>>
>> Fix for JDK-8240218
>
> The pull request has been updated with 1 additional commit.
Marked as reviewed by kcr (Lead).
-
PR:
On Fri, 21 Feb 2020 06:33:02 GMT, Arun Joseph wrote:
>> We currently use libxml2 version 2.9.9. We should update to the latest
>> stable release 2.9.10.
>
> The pull request has been updated with 1 additional commit.
Build + sanity tests are ok on win/mac/linux
-
Marked as
> Make modifications to javafx.web files for iOS, so that it can compile again.
>
> Fix for JDK-8240218
The pull request has been updated with 1 additional commit.
-
Added commits:
- e3330bfc: move HTMLEditorSkin.java into javafx.scene.web package
Changes:
- all:
On Fri, 28 Feb 2020 13:54:06 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The HTMLEditorSkin class needs to move to match the package declaration. The
> rest looks fine.
It's still not in the right place.
-
PR:
> Make modifications to javafx.web files for iOS, so that it can compile again.
>
> Fix for JDK-8240218
The pull request has been updated with 1 additional commit.
-
Added commits:
- 339b8314: Move HTMLEditorSkin to the correct package
Changes:
- all:
On Fri, 28 Feb 2020 11:58:22 GMT, Johan Vos wrote:
> Make modifications to javafx.web files for iOS, so that it can compile again.
>
> Fix for JDK-8240218
The HTMLEditorSkin class needs to move to match the package declaration. The
rest looks fine.
On Fri, 28 Feb 2020 12:00:23 GMT, Ajit Ghaisas wrote:
>> Also, I'm a bit weary about the "else if" (vs a simple "else") - wouldn't it
>> be some kind of setup error if the node orientation is neither rtl nor ltr?
>> If so, I would add a test to check for it once.
>
> Initially I had thought
Make modifications to javafx.web files for iOS, so that it can compile again.
Fix for JDK-8240218
-
Commits:
- 1b18d0b1: Make modifications to javafx.web files for iOS, so that it can
compile again.
Changes: https://git.openjdk.java.net/jfx/pull/128/files
Webrev:
On Tue, 25 Feb 2020 15:10:50 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
>> line 1141:
>>
>>> 1140: keyboard.doLeftArrowPress(KeyModifier.getShortcutKey());
>>> 1141: }
>>> 1142:
On Fri, 28 Feb 2020 01:19:23 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> I finished my review and tested this on all platforms. It looks good to me.
>
> The only comment I have is the one inline comment I left in `KeyCodeMap.java`
> about
18 matches
Mail list logo
