Re: [Integrated] RFR: 8240832: Remove unused applecoreaudio.md third-party legal file

2020-03-11 Thread Kevin Rushforth
Changeset: 9ea7f96e Author:Kevin Rushforth Date: 2020-03-10 21:33:51 + URL: https://git.openjdk.java.net/jfx/commit/9ea7f96e 8240832: Remove unused applecoreaudio.md third-party legal file Reviewed-by: almatvee - modules/javafx.media/src/main/legal/applecoreaudio.md

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-03-11 Thread Kevin Rushforth
On Tue, 10 Mar 2020 22:41:26 GMT, Kevin Rushforth wrote: >> @kevinrushforth Can you have a look at the test app? I would like to get >> this moving so we would have time to get the >> rest of the lighting enhancements into 15. > > I'll take a look. My quick thought is that we need some sort of t

Re: [Rev 04] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-11 Thread Kevin Rushforth
On Wed, 11 Mar 2020 12:43:40 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8200224 >> cleaned up code based on code review > > modules/javafx.controls/src/main/java/javafx/scene/cont

Re: [Rev 04] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-11 Thread Ambarish Rapte
On Tue, 10 Mar 2020 14:35:59 GMT, Florian Kirmaier wrote: >> Hi everyone, >> >> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 >> >> The fix itself is quite straight forward. >> It basically just removed the listener which causes the leak. >> >> The unit-test for the fix is a bit mo