Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-28 Thread Thiago Milczarek Sayao
> Simple fix to remove annoying warnings. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Sep cppFlags and cFlags - Changes: - all: https://git.openjdk.java.net/jfx/pull/150/files - new:

Re: [Rev 01] RFR: 8236840: Memory leak when switching ButtonSkin

2020-03-28 Thread Jeanette Winzenburg
On Sat, 28 Mar 2020 06:42:06 GMT, Ambarish Rapte wrote: >> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which >> results in leaking the `ButtonSkin` itself when >> the `Button`'s skin is changed to a new `ButtonSkin`. Using a >> `WeakChangeListener` instead of

Re: [Rev 01] RFR: 8236840: Memory leak when switching ButtonSkin

2020-03-28 Thread Ambarish Rapte
> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results > in leaking the `ButtonSkin` itself when > the `Button`'s skin is changed to a new `ButtonSkin`. Using a > `WeakChangeListener` instead of `ChangeListener` solves > the issue. > Please take a look. Ambarish Rapte

Re: RFR: 8236840: Memory leak when switching ButtonSkin

2020-03-28 Thread Ambarish Rapte
On Fri, 27 Mar 2020 12:12:30 GMT, Ambarish Rapte wrote: >> In general, there are two approaches to avoiding listener-related memory >> leaks. One is to use a WeakListener; the other >> is to explicitly remove the listener when the object is removed or otherwise >> no longer needed. >> Using a