Re: RFR: 8242106: [macos] Remove obsolete GlassView2D.m class

2020-04-07 Thread Ambarish Rapte
On Tue, 7 Apr 2020 13:54:43 GMT, Kevin Rushforth wrote: > This is a simple fix to remove some obsolete code. As noted in the JBS > description, GlassView2D was made obsolete back > in JDK 8, but the GlassView2D.m / .h class files were left in the repo. It is > dead code, as there are no

RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

2020-04-07 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8240694 - Original fix JDK-8236832 was reverted. - Timestamp will be queried on event loop thread when spectrum event is received by event loop. - FIx only enabled for macOS when using OSXPlatform. - Commit messages: - 8240694: [macos

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-04-07 Thread Kevin Rushforth
On Tue, 31 Mar 2020 20:45:44 GMT, Thiago Milczarek Sayao wrote: >> I took a look yesterday and came to the same conclusion that what we really >> want are separate C and C++ flags. For now, >> the only difference would be the presence or absence of >> `-Werror=implicit-function-declaration`,

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-04-07 Thread Kevin Rushforth
On Thu, 2 Apr 2020 12:59:11 GMT, Nir Lisker wrote: >> I have added few comments, but have not run tests and sample yet. > > @arapte Can you please test the performance changes too? I think @arapte has a similar MacBookPro model to mine. I think @prrace might be able to test it (I'll sync with

Re: [Rev 01] RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Kevin Rushforth
On Tue, 7 Apr 2020 11:40:09 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8241710 >> >> Root Cause : A menu can have empty submenu. This was not checked while >> processing RIGHT arrow key. >> >> Fix : Added the null check for submenu. Added a unit test case which

Re: [Rev 48] RFR: 8236651: Simplify and update glass gtk backend

2020-04-07 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > *

Re: RFR: 8242209: Increase web native thread stack size for x86 mode

2020-04-07 Thread Kevin Rushforth
On Mon, 6 Apr 2020 11:57:54 GMT, Arun Joseph wrote: > CLoop interpreter used in 32-bit Windows uses 87 KB of stack space each time > CLoop::execute() is called. For web native > threads which has a default stack size of 320 KB, a Stack Overflow Error is > raised just after two calls to

Re: RFR: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)

2020-04-07 Thread Kevin Rushforth
On Wed, 1 Apr 2020 10:49:22 GMT, Ajit Ghaisas wrote: > Bug : https://bugs.openjdk.java.net/browse/JDK-8230809 > > Root Cause : > Turned out to be a simpler issue than thought. > Atomicity check was missed while updating toolbar state (which in turn > updates styles). > > Fix : > Added the

Re: RFR: 8242209: Increase web native thread stack size for x86 mode

2020-04-07 Thread Kevin Rushforth
On Mon, 6 Apr 2020 11:57:54 GMT, Arun Joseph wrote: > CLoop interpreter used in 32-bit Windows uses 87 KB of stack space each time > CLoop::execute() is called. For web native > threads which has a default stack size of 320 KB, a Stack Overflow Error is > raised just after two calls to

Re: RFR: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)

2020-04-07 Thread Arun Joseph
On Wed, 1 Apr 2020 10:49:22 GMT, Ajit Ghaisas wrote: > Bug : https://bugs.openjdk.java.net/browse/JDK-8230809 > > Root Cause : > Turned out to be a simpler issue than thought. > Atomicity check was missed while updating toolbar state (which in turn > updates styles). > > Fix : > Added the

Re: RFR: 8242106: [macos] Remove obsolete GlassView2D.m class

2020-04-07 Thread Kevin Rushforth
On Tue, 7 Apr 2020 13:54:43 GMT, Kevin Rushforth wrote: > This is a simple fix to remove some obsolete code. As noted in the JBS > description, GlassView2D was made obsolete back > in JDK 8, but the GlassView2D.m / .h class files were left in the repo. It is > dead code, as there are no

RFR: 8242106: [macos] Remove obsolete GlassView2D.m class

2020-04-07 Thread Kevin Rushforth
This is a simple fix to remove some obsolete code. As noted in the JBS description, GlassView2D was made obsolete back in JDK 8, but the GlassView2D.m / .h class files were left in the repo. It is dead code, as there are no references to that class. - Commit messages: - 8242106:

Re: Support "trust all" SSL context in OpenJFX 14

2020-04-07 Thread Lior Yaffe
I'm not sure why but it doesn't work. The only workaround I found is: System.setProperty("com.sun.webkit.useHTTP2Loader", "false"); // Workaround to support test certificate with OpenJFX 14 Webview Then use the old code which works in OpenJFX 13 and earlier.

Re: Shared buffer in PixelBuffer

2020-04-07 Thread Kevin Rushforth
Thanks for sharing. -- Kevin On 4/7/2020 1:39 AM, Michael Paus wrote: Hi, it is nice to hear that you could make some good use of this work. Michael (mipastgt) Am 07.04.20 um 02:36 schrieb hohonu...@icloud.com: Hi All, I just wanted to send a "thank you!" to all the JavaFX devs for your

Re: RFR: 8242167: ios keyboard handling

2020-04-07 Thread Kevin Rushforth
On Sun, 5 Apr 2020 14:09:32 GMT, Johan Vos wrote: > Use JavaFX controls for TextField and TextArea instead of the native iOS ones > This fixes JDK-8242167 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/158

Re: RFR: 8242163: Android keyboard integration fails

2020-04-07 Thread Kevin Rushforth
On Sun, 5 Apr 2020 10:19:07 GMT, Johan Vos wrote: > Fix the code that integrates TextField/TextArea with the android keyboard > > Fix for #8242163 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/157

Re: [Rev 01] RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Jeanette Winzenburg
On Tue, 7 Apr 2020 11:40:09 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8241710 >> >> Root Cause : A menu can have empty submenu. This was not checked while >> processing RIGHT arrow key. >> >> Fix : Added the null check for submenu. Added a unit test case which

Re: [Rev 01] RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Ajit Ghaisas
On Tue, 7 Apr 2020 11:40:09 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8241710 >> >> Root Cause : A menu can have empty submenu. This was not checked while >> processing RIGHT arrow key. >> >> Fix : Added the null check for submenu. Added a unit test case which

Re: [Rev 01] RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Ajit Ghaisas
> Bug : https://bugs.openjdk.java.net/browse/JDK-8241710 > > Root Cause : A menu can have empty submenu. This was not checked while > processing RIGHT arrow key. > > Fix : Added the null check for submenu. Added a unit test case which fails > without fix and passes with it. Ajit Ghaisas has

Re: [Rev 01] RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Ajit Ghaisas
On Tue, 7 Apr 2020 10:13:39 GMT, Jeanette Winzenburg wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor review fixes > >

Re: Support "trust all" SSL context in OpenJFX 14

2020-04-07 Thread Michał Zegan
What about global SSLContext.setDefault()? maybe it doesn't apply of course. W dniu 07.04.2020 o 13:14, Lior Yaffe pisze: > Some background information on why we are facing the issue. > The internal implementation of WebView changed in OpenJFX 14 to use > HttpClient instead of

Support "trust all" SSL context in OpenJFX 14

2020-04-07 Thread Lior Yaffe
Some background information on why we are facing the issue. The internal implementation of WebView changed in OpenJFX 14 to use HttpClient instead of Http(s)URLConnection. Therefore, it is no longer possible to use the following methods to set a custom SSL context before instantiation of a

Re: RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Jeanette Winzenburg
On Tue, 7 Apr 2020 07:36:00 GMT, Ajit Ghaisas wrote: > Bug : https://bugs.openjdk.java.net/browse/JDK-8241710 > > Root Cause : A menu can have empty submenu. This was not checked while > processing RIGHT arrow key. > > Fix : Added the null check for submenu. Added a unit test case which fails

Re: RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

2020-04-07 Thread Ambarish Rapte
On Mon, 30 Mar 2020 13:37:51 GMT, Florian Kirmaier wrote: > Closed focused Stages are not collected with Monocle > > This commit adds a unit-test and a fix for collecting focused closed stages. > > ticket: https://bugs.openjdk.java.net/browse/JDK-8241840 Suggested some changes and query. I

Re: Shared buffer in PixelBuffer

2020-04-07 Thread Michael Paus
Hi, it is nice to hear that you could make some good use of this work. Michael (mipastgt) Am 07.04.20 um 02:36 schrieb hohonu...@icloud.com: Hi All, I just wanted to send a "thank you!" to all the JavaFX devs for your work on JavaFX and most especially, adding shared memory to JavaFX’s

Re: RFR: 8242163: Android keyboard integration fails

2020-04-07 Thread Johan Vos
On Mon, 6 Apr 2020 23:26:12 GMT, Kevin Rushforth wrote: >> Fix the code that integrates TextField/TextArea with the android keyboard >> >> Fix for #8242163 > > Similar question as for the IOS keyboard issue: The newly moved > `TextAreaSkinAndroid ` and `TextFieldSkinAndroid` > classes will

Re: RFR: 8242167: ios keyboard handling

2020-04-07 Thread Johan Vos
On Mon, 6 Apr 2020 23:21:17 GMT, Kevin Rushforth wrote: > The new `TextAreaSkinIos` and `TextFieldSkinIos ` classes will become part of > the public API for IOS, since they are in > the `javafx.scene.control.skin` package. Is this intended, or might they be > able to live somewhere under >

RFR: 8241710: NullPointerException while entering empty submenu with "arrow right"

2020-04-07 Thread Ajit Ghaisas
Bug : https://bugs.openjdk.java.net/browse/JDK-8241710 Root Cause : A menu can have empty submenu. This was not checked while processing RIGHT array key. Fix : Added the null check for submenu. Added a unit test case which fails without fix and passes with it. - Commit messages: