On Wed, 22 Apr 2020 18:46:29 GMT, Kevin Rushforth wrote:
> This PR adds support for Microsoft Visual Studio 2019 (VS 2019), but does not
> change the default compiler, which
> remains at VS 2017 15.9.16. Changing the build compiler to VS 2019 will be
> proposed in a future PR using a new bug
On Tue, 5 May 2020 10:57:23 GMT, Florian Kirmaier wrote:
>> I would suggest making everything configurable in the original library which
>> will be suggested here to be changed.
>> I will now add the possibility to make the creation of the heapDump
>> configurable, and also the createGarbage
> It's based on the discussion of my previous PR:
> https://github.com/openjdk/jfx/pull/71
>
> I Added test utility class copied from JMemoryBuddy and used it to simplify 4
> of the existing unit tests.
>
> It's a direct copy of my project
>
`VirtualFlow` makes use of `VirtualScrollBar` controls, that are laid out next
to the clipped container region, by
default.
However, when touch is supported, these scrollBars are floating controls laid
out over the container. Therefore, in
this case, when the viewport dimensions are updated,
On Mon, 27 Apr 2020 08:17:50 GMT, Arun Joseph wrote:
> ScrollbarThemeJava delegates scrollbar thickness calculation to
> ScrollBarWidget::initializeThickness()
> [ScrollBarWidget.java] method. Since "ScrollbarThemeJava::scrollbarThickness"
> is not associated with any
> "ScrollBarWidget"
On Mon, 4 May 2020 09:07:53 GMT, Ajit Ghaisas wrote:
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244110
>
> Root Cause :
> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
> code to remove accelerators from a scene
> in Scene property listener of
On Tue, 5 May 2020 11:07:43 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244110
>>
>> Root Cause :
>> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
>> code to remove accelerators from a scene
>> in Scene property listener of
On Tue, 5 May 2020 13:53:02 GMT, Jeanette Winzenburg
wrote:
>
>
> not sure if it is appropriate to approve this? we talked so much about it,
> that it feels like self-approval :)
Please do approve it. And thank you for contributing the solution and test.
-
PR:
On Tue, 5 May 2020 12:38:26 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make ChangeListener Final
>
> Looks good. I confirm that the original system test and the new controls unit
> test
On Wed, 22 Apr 2020 18:46:29 GMT, Kevin Rushforth wrote:
> This PR adds support for Microsoft Visual Studio 2019 (VS 2019), but does not
> change the default compiler, which
> remains at VS 2017 15.9.16. Changing the build compiler to VS 2019 will be
> proposed in a future PR using a new bug
On Tue, 5 May 2020 11:07:43 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244110
>>
>> Root Cause :
>> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
>> code to remove accelerators from a scene
>> in Scene property listener of
On Tue, 5 May 2020 10:35:12 GMT, Ajit Ghaisas wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuButtonSkinBase.java
>> line 230:
>>
>>> 229: // Remove listeners
>>> 230:
>>> getSkinnable().sceneProperty().removeListener(sceneChangeListener);
>>>
> It's based on the discussion of my previous PR:
> https://github.com/openjdk/jfx/pull/71
>
> I Added test utility class copied from JMemoryBuddy and used it to simplify 4
> of the existing unit tests.
>
> It's a direct copy of my project
>
On Mon, 4 May 2020 13:47:58 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Updated JMemoeryBuddy
>> Added Copyright header
>> disabled default heapdump
>
>
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244110
>
> Root Cause :
> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
> code to remove accelerators from a scene
> in Scene property listener of MenuButtonSkinBase. That fix uses
> getSkinnable() in listener.
On Mon, 4 May 2020 15:46:57 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make ChangeListener Final
>
>
On Tue, 5 May 2020 10:38:56 GMT, Florian Kirmaier wrote:
>> I'll put this on my queue to review and test it. I left some high-level
>> comments below.
>
> I would suggest making everything configurable in the original library which
> will be suggested here to be changed.
> I will now add the
The issue is that ChoiceBox didn't sync its value to the replaced
SelectionModel's selectedItem if the item is null.
Fixed by removing the constraint from selectionModel property.
Added tests that failed before and passed after the fix. Note that I also
changed a test method in ChoiceBoxTest
On Mon, 4 May 2020 14:24:48 GMT, Kevin Rushforth wrote:
>> It's based on the discussion of my previous PR:
>> https://github.com/openjdk/jfx/pull/71
>>
>> I Added test utility class copied from JMemoryBuddy and used it to simplify
>> 4 of the existing unit tests.
>>
>> It's a direct copy of
On Tue, 28 Apr 2020 15:36:53 GMT, Jeanette Winzenburg
wrote:
> The issue is that the toggles is not reliably unselected if an uncontained
> value is set.
>
> The root is ChoiceBoxSelectionModel which doesn't update the index on
> selecting an uncontained item, in particular it
> fails to
20 matches
Mail list logo
