Re: [Rev 02] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-17 Thread Ajit Ghaisas
> Issue : > https://bugs.openjdk.java.net/browse/JDK-8244418 > > Root Cause : > Incorrect assumption about menu list size. > > Fix : > Added check for empty menu list before trying to access it. > > Test : > Added a unit test that fails before fix and passes after it. Ajit Ghaisas has updated t

Re: [Rev 02] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-17 Thread Ajit Ghaisas
On Fri, 15 May 2020 09:29:27 GMT, Jeanette Winzenburg wrote: >> I differ on this suggestion. >> My thinking is - list access in setFocusedMenuIndex() method should have >> this check. It is not up to the caller to know >> the internal details of the method. That's the root cause of Exception. I

Re: [Rev 01] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-17 Thread Ajit Ghaisas
On Sun, 17 May 2020 10:04:58 GMT, Jeanette Winzenburg wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review_fixes > > modules/javafx.controls/src/test/java/test/javafx/scene/control/MenuBarTest.java > line 134:

Re: [Rev 02] RFR: 8218973: SVG with masking is not rendering image with mask effect

2020-05-17 Thread Arun Joseph
On Sun, 10 May 2020 20:49:07 GMT, Bhawesh Choudhary wrote: >> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp >> in WebKit was not implemented, so masking >> doesn't take place at all while rendering SVGRect. to fix this issue add >> implementation of function clipT

Re: [Rev 01] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-17 Thread Jeanette Winzenburg
On Tue, 12 May 2020 12:27:11 GMT, Ajit Ghaisas wrote: >> Issue : >> https://bugs.openjdk.java.net/browse/JDK-8244418 >> >> Root Cause : >> Incorrect assumption about menu list size. >> >> Fix : >> Added check for empty menu list before trying to access it. >> >> Test : >> Added a unit test tha