Re: [Rev 03] RFR: 8218973: SVG with masking is not rendering image with mask effect

2020-05-18 Thread Arun Joseph
On Mon, 18 May 2020 08:00:38 GMT, Bhawesh Choudhary wrote: >> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp >> in WebKit was not implemented, so masking >> doesn't take place at all while rendering SVGRect. to fix this issue add >> implementation of function

Re: RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-18 Thread Jeanette Winzenburg
On Mon, 18 May 2020 13:27:52 GMT, Jeanette Winzenburg wrote: >> I have not reviewed this PR yet, but a quick comment - Can we enable and >> fix currently Ignored ControlSkinTest with >> this? > >> Can we enable and fix currently Ignored ControlSkinTest with this? > > will check, always

Re: RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-18 Thread Jeanette Winzenburg
On Mon, 18 May 2020 12:29:05 GMT, Ajit Ghaisas wrote: > Can we enable and fix currently Ignored ControlSkinTest with this? will check, always ignored that test :) - PR: https://git.openjdk.java.net/jfx/pull/223

Re: RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-18 Thread Ajit Ghaisas
On Mon, 18 May 2020 12:07:30 GMT, Jeanette Winzenburg wrote: > It's a task to support cross-control/skin testing for recurring issues (like > memory leaks on switching skins) > > Basically, there's a utility class > - to access lists of all control/classes, > - to access/create all behaviors

RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-18 Thread Jeanette Winzenburg
It's a task to support cross-control/skin testing for recurring issues (like memory leaks on switching skins) Basically, there's a utility class - to access lists of all control/classes, - to access/create all behaviors - has alternative skins classes for all controls and utility to

Re: [Integrated] RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

2020-05-18 Thread Ambarish Rapte
On Wed, 29 Apr 2020 04:40:59 GMT, Ambarish Rapte wrote: > Issue: > When tabs are permuted as mentioned in the issue description as, > 1. TabPane.getTabs().setAll(tab0, tab1) > 2. TabPane.getTabs().setAll(tab0, tab1, tab2, tab3); > the tab headers do not get permuted in same order as

Re: [Rev 01] RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

2020-05-18 Thread Jeanette Winzenburg
On Mon, 11 May 2020 04:12:22 GMT, Ambarish Rapte wrote: >> Issue: >> When tabs are permuted as mentioned in the issue description as, >> 1. TabPane.getTabs().setAll(tab0, tab1) >> 2. TabPane.getTabs().setAll(tab0, tab1, tab2, tab3); >> the tab headers do not get permuted in same order as

Re: [Rev 02] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-18 Thread Jeanette Winzenburg
On Mon, 18 May 2020 05:52:21 GMT, Ajit Ghaisas wrote: >> Issue : >> https://bugs.openjdk.java.net/browse/JDK-8244418 >> >> Root Cause : >> Incorrect assumption about menu list size. >> >> Fix : >> Added check for empty menu list before trying to access it. >> >> Test : >> Added a unit test

Re: [Rev 02] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-18 Thread Jeanette Winzenburg
On Mon, 18 May 2020 05:42:17 GMT, Ajit Ghaisas wrote: >> hmm .. yeah I'm aware of getContainer vs. getMenus - but they should be the >> same size, shouldn't they? >> >> Anyway, if focusedIndex != getMenus().indexOf all users of focusedIndex have >> to include a check for validity. That >>

Re: [Rev 03] RFR: 8218973: SVG with masking is not rendering image with mask effect

2020-05-18 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image

Re: [Rev 01] RFR: 8181775: JavaFX WebView does not calculate border-radius properly

2020-05-18 Thread Bhawesh Choudhary
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp while > rendering fillRoundedRect, check if all four corners have