On Tue, 26 May 2020 17:33:20 GMT, Jose Pereda wrote:
>> After JDK-8242167, a JavaFX control is used for text input on iOS instead of
>> the native control, on a touch enabled
>> device. However, selection handles are not enabled and currently text
>> selection is not possible at all.
>> This
On Tue, 26 May 2020 11:12:25 GMT, Ambarish Rapte wrote:
> Copied from JBS:
> As a best practice, unit test classes that are run by Junit should not extend
> javafx.application.Application.
> JUnit constructs an instance of a test class for each test method that it
> runs. This will be
On Tue, 26 May 2020 09:27:52 GMT, Arun Joseph wrote:
> Cause: The test assumes that WebView/WebPage will be GCed right after
> `System.gc()`
>
> Fix: Use `runFinalization()` and `sleep()` to wait for objects to get GCed
Marked as reviewed by kcr (Lead).
-
PR:
On Tue, 26 May 2020 11:12:25 GMT, Ambarish Rapte wrote:
> Copied from JBS:
> As a best practice, unit test classes that are run by Junit should not extend
> javafx.application.Application.
> JUnit constructs an instance of a test class for each test method that it
> runs. This will be
On Wed, 13 May 2020 08:46:11 GMT, Rony G. Flatscher
wrote:
>> This WIP adds the ability for a fallback in case compilation of scripts
>> fails, in which case a warning gets issued
>> about this fact and evaluation of the script will be done without
>> compilation. Because of the fallback
On Fri, 24 Apr 2020 00:58:30 GMT, Nir Lisker wrote:
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with
This is waiting on me. I need to review the updated API docs and CSR
test, and then create a draft CSR issue.
-- Kevin
On 5/23/2020 11:30 AM, Rony G Flatscher wrote:
Hi Kevin,
is there anything I need to do? What are the next steps I should look for?
—-rony
Rony G. Flatscher (mobil/e)
On Mon, 13 Apr 2020 18:56:36 GMT, Johan Vos wrote:
>> The root cause for this issue is not the unnecessary logging, but the fact
>> that the Quantum Renderer keeps running when
>> the app is not in the foreground (causing a long list of debug lines). I'll
>> create a separate issue for that.
>
On Tue, 26 May 2020 11:42:46 GMT, Ajit Ghaisas wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new line at the end of the file
>
>
On Tue, 26 May 2020 11:46:54 GMT, Ajit Ghaisas wrote:
>> Since this touches shared code, I'd like @aghaisas to look at this.
>
> Code changes look OK.
> I think, we need a note in PR description about what testing you have done
> with this fix.
I've edited the PR description with details of
> After JDK-8242167, a JavaFX control is used for text input on iOS instead of
> the native control, on a touch enabled
> device. However, selection handles are not enabled and currently text
> selection is not possible at all.
> This PR enables handles on iOS as in the rest of the platforms
On 5/25/20 11:47 AM, Philip Race wrote:
Mmm .. it can't be the same bug even if the effect is similar.
We don't use freetype on macOS, that's for Linux.
Right. I meant the same visible bug (severe color fringes).
Can you check your display's settings ?
I'm using a Dell UltraSharp U2715H
Both skins have similar misbehavior when switching skins
- memory leak due to a manually added but not removed change listener
- NPE when modifying items after skin switch due to a not removed listener to
the control's items
Fixed in both (for details see the issue). Added SkinCleanupTest for
On Thu, 21 May 2020 17:41:02 GMT, Jose Pereda wrote:
> After JDK-8242167, a JavaFX control is used for text input on iOS instead of
> the native control, on a touch enabled
> device. However, selection handles are not enabled and currently text
> selection is not possible at all.
> This PR
On Thu, 21 May 2020 18:11:59 GMT, Kevin Rushforth wrote:
>> After JDK-8242167, a JavaFX control is used for text input on iOS instead of
>> the native control, on a touch enabled
>> device. However, selection handles are not enabled and currently text
>> selection is not possible at all.
>>
On Mon, 11 May 2020 04:44:27 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
Copied from JBS:
As a best practice, unit test classes that are run by Junit should not extend
javafx.application.Application.
JUnit constructs an instance of a test class for each test method that it runs.
This will be different from the
instance of the object that is constructed when
Cause: The test assumes that WebView/WebPage will be GCed right after
`System.gc()`
Fix: Use `runFinalization()` and `sleep()` to wait for objects to get GCed
-
Commit messages:
- Update copyright year
- Remove unwanted line
- 8234540: javafx.web
18 matches
Mail list logo
