Re: [Rev 02] RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

2020-06-04 Thread Rony G . Flatscher
> This PR adds a "compile" process instruction to FXML files with the optional > PI data "true" (default) and "false". The > PI data is turned into a boolean value using "Boolean.parseBoolean(String)". > This makes it possible to inject the compile PI everywhere in a FXML file and > turn on and

Re: [Rev 01] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-04 Thread Jeanette Winzenburg
On Thu, 4 Jun 2020 11:23:42 GMT, Ambarish Rapte wrote: > > > > The other selectionModels for virtualized controls try to keep the > > selectedItem/Index only. > > Keeping the selection after sort/permutation seems more correct from a user's > perspective. I did not look into how > other

Re: [Integrated] RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux

2020-06-04 Thread Michael Paus
On Mon, 1 Jun 2020 17:52:46 GMT, Michael Paus wrote: > It seems to be sufficient to add "intel" as an additional vendor to the list > in the X11GLFactory class. Tests pass and > my own application also works with the new build. This pull request has now been integrated. Changeset: 97499820

Re: [Rev 01] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-04 Thread Ambarish Rapte
On Wed, 3 Jun 2020 12:03:43 GMT, Jeanette Winzenburg wrote: > The other selectionModels for virtualized controls try to keep the > selectedItem/Index only. Keeping the selection after sort/permutation seems more correct from a user's perspective. I did not look into how other controls handle

Re: [Rev 01] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-04 Thread Ambarish Rapte
On Wed, 3 Jun 2020 13:45:12 GMT, Kevin Rushforth wrote: > Update: I am testing with 7 level of nested rows, with 10, 9, 7, 6, 5, 4, 3 > number of children in each level > respectively. The fix works fine till level 3. But can observe issue with > level 4 and further. Shall debug this more >

RFR: 8246195: ListViewSkin/Behavior: misbehavior on switching skin

2020-06-04 Thread Jeanette Winzenburg
Cleanup memory leaks and malicious side-effects (produced by eventhandlers and listeners that were not removed) when replacing a ListViewSkin. The fix is to remove the listeners/handlers as needed. Added tests that failed before and pass after the fix. It's part of the ongoing cleanup effort

Re: CFV: New OpenJFX Reviewer: Nir Lisker

2020-06-04 Thread Ajit Ghaisas
Vote: YES Regards, Ajit > On 03-Jun-2020, at 6:58 PM, Kevin Rushforth > wrote: > > I hereby nominate Nir Lisker [1] to OpenJFX Reviewer. > > Nir is an OpenJFX community member, who has contributed 29 changesets [2][3] > to OpenJFX over the course of the past 2 years. Nir consistently

Re: [Rev 01] RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux

2020-06-04 Thread Michael Paus
> It seems to be sufficient to add "intel" as an additional vendor to the list > in the X11GLFactory class. Tests pass and > my own application also works with the new build. Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Remove

Re: [Rev 01] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-04 Thread Jeanette Winzenburg
On Wed, 3 Jun 2020 13:45:12 GMT, Kevin Rushforth wrote: >>> The algorithm looks correct to me for sorting. How much regression testing >>> have you done for cases where rows or >>> columns are inserted? >> >> I have tested with a small TreeTableView of 15 rows of 3 levels and 3 >> columns. >>

RE: CFV: New OpenJFX Reviewer: Nir Lisker

2020-06-04 Thread Ambarish Rapte
Vote: YES Regards, Ambarish