Re: [jfx15] RFR: 8248381: Create a daemon thread for MonocleTimer

2020-07-02 Thread John Neffenger
On Thu, 2 Jul 2020 23:46:40 GMT, Kevin Rushforth wrote: > Given that this is a regression introduced in JavaFX 14, this fix seems like > a good candidate for JavaFX 15 ... Actually, this is a regression introduced in JavaFX 15, so we have the chance to fix it before it's ever released. > Go a

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v2]

2020-07-02 Thread Kevin Rushforth
On Tue, 30 Jun 2020 18:28:11 GMT, Oliver Schmidtmer wrote: >> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and >> Math.round produce different results and >> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one >> error on the line width and there

Re: RFR: 8244212: Optionally download media and webkit libraries from latest openjfx EA build

2020-07-02 Thread Nir Lisker
On Wed, 1 Jul 2020 18:27:01 GMT, Johan Vos wrote: >> Do the build instructions need to be updated? > > The build instruction can indeed refer to WEBKIT-MEDIA-STUBS.md now. I updated https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-PlatformPrerequisites. --

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v2]

2020-07-02 Thread Kevin Rushforth
On Tue, 30 Jun 2020 18:21:52 GMT, Oliver Schmidtmer wrote: >> In 2D, we normally use sun.java2d.pipe.Region.clipRound as it also checks >> for -ve/+ve max INTEGER but I guess that is >> internal class to FX so it's ok to use Math.round. Approval pending test >> creation. > > While both might

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread [v2]

2020-07-02 Thread Kevin Rushforth
On Thu, 2 Jul 2020 12:41:34 GMT, Kevin Rushforth wrote: >> I tested this pull request on all of the following platforms: >> >> * JavaFX desktop platforms (*amd64* architecture) >> * Windows SDK on Windows 10 Pro Version 2004 >> * Mac OS X SDK on macOS 10.15.5 (Catalina) >> * Linux SD

Re: RFR: 8248381: Create a daemon thread for MonocleTimer

2020-07-02 Thread Kevin Rushforth
On Mon, 29 Jun 2020 11:33:24 GMT, Johan Vos wrote: >> I think the code in the `_stop` method is correct after all. >> >> The `MonocleTimer` class is written to allow for multiple calls to the pair >> of `_start` and `_stop` methods (even >> though I don't think that ever happens), and the stati

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v6]

2020-07-02 Thread Kevin Rushforth
On Tue, 30 Jun 2020 23:14:52 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8176270: Adding ChangeListener to TextField.selectedTextProperty causes >> StringOutOfBoundsException >>

JBS bugs and enhancements still targeted to openjfx15

2020-07-02 Thread Kevin Rushforth
To: OpenJFX Authors, Committers, and Reviewers Now that we are in the rampdown for openjfx15, I ask everyone who is an Author, Committer, or Reviewer in the OpenJFX project, and who has a JBS issue targeted to openjfx15 (that is, "fixversion==openjfx15"), to look at their JBS issues and move t

JavaFX 15 is in Rampdown Phase One (RDP1)

2020-07-02 Thread Kevin Rushforth
JavaFX 15 is now in Rampdown Phase One (RDP1) [1]. We have forked a new jfx15 branch [2] for stabilizing the JavaFX 15 release. Here is the short summary of what this means: - The master branch of the jfx repo is available for integrating bug fixes or enhancements for openjfx16. Most fixes wil

Integrated: 8248317: Change JavaFX release version to 16

2020-07-02 Thread Kevin Rushforth
On Tue, 30 Jun 2020 15:30:31 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 16. I will integrate this immediately > after forking the `jfx15` stabilization > branch. This pull request has now been integrated. Changeset: a4f31505 Author:Kevin Rushforth URL: https:

Integrated: 8201570: Get two bytes for the Linux input event type, not four

2020-07-02 Thread John Neffenger
On Sat, 27 Jun 2020 00:12:41 GMT, John Neffenger wrote: > Fixes [JDK-8201570](https://bugs.openjdk.java.net/browse/JDK-8201570). This pull request has now been integrated. Changeset: 126637f5 Author:John Neffenger Committer: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/12

Integrated: 8247963: Update SQLite to version 3.32.3

2020-07-02 Thread Arun Joseph
On Wed, 1 Jul 2020 17:14:30 GMT, Arun Joseph wrote: > We currently use SQLite version 3.31.1. We should update to the latest stable > release version 3.32.3 released on > 2020-06-18. https://www.sqlite.org/index.html This pull request has now been integrated. Changeset: f3a04465 Author:Aru

Re: RFR: 8247963: Update SQLite to version 3.32.3

2020-07-02 Thread Guru Hb
On Wed, 1 Jul 2020 17:14:30 GMT, Arun Joseph wrote: > We currently use SQLite version 3.31.1. We should update to the latest stable > release version 3.32.3 released on > 2020-06-18. https://www.sqlite.org/index.html Looks good to me - Marked as reviewed by ghb (Reviewer). PR: ht

Re: MacOS Big Sur and OpenJFX on Arm Macs

2020-07-02 Thread Johan Vos
This is probably a toolchain issue indeed. There shouldn't be a real difference between OpenJFX and other Mac applications. It's probably (hopefully) just compiling/linking with a few specific flags to set the CPU. - Johan On Thu, Jul 2, 2020 at 2:51 PM Kevin Rushforth wrote: > At WWDC, Apple i

Re: MacOS Big Sur and OpenJFX on Arm Macs

2020-07-02 Thread Kevin Rushforth
At WWDC, Apple indicated that they have run the JDK on prototype Arm HW using Rosetta2. Once we get our hands on some HW we'll test JavaFX as well. I expect that it will run reasonably well. I think that an ARM port for JavaFX won't be too difficult, although I doubt the existence of Linux ARM

Re: RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread [v2]

2020-07-02 Thread Kevin Rushforth
On Wed, 1 Jul 2020 05:43:29 GMT, John Neffenger wrote: >>> It will also need to be tested using the SW pipeline on all platforms. >> >> Thanks for the reminder. I managed to build JavaFX on Windows and macOS >> today, so I'll test this pull request on those >> platforms in addition to Linux de