Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v4]

2020-07-27 Thread Kevin Rushforth
On Mon, 27 Jul 2020 21:16:41 GMT, Nir Lisker wrote: >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional >> fixes in the vicinity. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v3]

2020-07-27 Thread Kevin Rushforth
On Mon, 27 Jul 2020 20:52:57 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/VBox.java line 163: >> >>> 162: * If no vertical grow priority is set on a child, the vbox will >>> never >>> 163: * allocate it additional vertical space, if available.

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v4]

2020-07-27 Thread Nir Lisker
> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional > fixes in the vicinity. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all:

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v3]

2020-07-27 Thread Nir Lisker
On Mon, 27 Jul 2020 17:32:26 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> VBox and HBox fixes > > modules/javafx.graphics/src/main/java/javafx/scene/layout/VBox.java line 163: > >> 162:

[jfx15] RFR: 8228570: Add various documentation clarifications

2020-07-27 Thread Nir Lisker
Adds clarifications to the documentation in various places. Some notes: * Point 6 should probably be deferred until it is verified that the tutorials are correct enough, seeing as they were updated to Java 8 only. * Point 8 has been deferred until all the animation bugs have been resolevd. *

Re: A request for FXML exxamples (Re: [jfx15] Fix mistakes in FX API docs [v3]

2020-07-27 Thread Nir Lisker
Hi Rony, I think that this PR is not the place for this question since it only fixes a typo there. On Mon, Jul 27, 2020 at 4:12 PM Rony G. Flatscher wrote: > On 26.07.2020 12:10, Nir Lisker wrote: > >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some > additional fixes in the

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v3]

2020-07-27 Thread Kevin Rushforth
On Sun, 26 Jul 2020 10:10:09 GMT, Nir Lisker wrote: >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional >> fixes in the vicinity. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > VBox and HBox fixes

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-27 Thread torbuntu
On Mon, 27 Jul 2020 16:05:02 GMT, John Neffenger wrote: >>> By the way, do you know whether I would be able to use a PinePhone >> >> I have been trying to run JavaFX on the PinePhone ever since I got it. The >> OS I'm using is Fedora and it is aarch64, >> which means I had to add that arch to

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-27 Thread John Neffenger
On Mon, 27 Jul 2020 14:26:44 GMT, Tor (torbuntu) wrote: > Is there somewhere I can find an embedded aarch64 version? If I had a PinePhone, I would try to get the 32-bit *armhf* build of JavaFX working. That's the one you build with `gradle -PCOMPILE_TARGETS=armv6hf sdk jmod`. You may need to

Re: RFR: 8201568: zForce touchscreen input device fails when closed and immediately reopened

2020-07-27 Thread torbuntu
On Thu, 9 Jul 2020 22:35:01 GMT, John Neffenger wrote: > By the way, do you know whether I would be able to use a PinePhone I have been trying to run JavaFX on the PinePhone ever since I got it. The OS I'm using is Fedora and it is aarch64, which means I had to add that arch to build.gradle to

A request for FXML exxamples (Re: [jfx15] Fix mistakes in FX API docs [v3]

2020-07-27 Thread Rony G. Flatscher
On 26.07.2020 12:10, Nir Lisker wrote: >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional >> fixes in the vicinity. > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > VBox and HBox fixes > > -

Re: [jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors [v2]

2020-07-27 Thread Ajit Ghaisas
> Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 > Fix : Added missing explicit no-arg constructors to classes in package > javafx.beans.binding in module javafx.base. Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:

Re: [jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

2020-07-27 Thread Ajit Ghaisas
On Mon, 27 Jul 2020 10:16:07 GMT, Jeanette Winzenburg wrote: > The single sentence of the min doc should end with a period, iirc ;) Thanks. Yes, I missed out on it.. will fix soon. - PR: https://git.openjdk.java.net/jfx/pull/275

Re: [jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

2020-07-27 Thread Jeanette Winzenburg
On Mon, 27 Jul 2020 10:07:31 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 > Fix : Added missing explicit no-arg constructors to classes in package > javafx.beans.binding in module javafx.base. The single sentence of the min doc should end with a period,

[jfx15] RFR: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

2020-07-27 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8249647 Fix : Added missing explicit no-arg constructors to classes in package javafx.beans.binding in module javafx.base. - Commit messages: - add explicit constructors Changes: https://git.openjdk.java.net/jfx/pull/275/files