Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Arun Joseph
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Arun Joseph
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-01 Thread Kevin Rushforth
On Tue, 1 Sep 2020 22:46:44 GMT, Nir Lisker wrote: >> You need to pass a flag to enable system tests (and a second one for Robot >> tests, but if you use snapshot it might not >> need to be). >> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest > >> gradle

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-01 Thread Nir Lisker
On Tue, 1 Sep 2020 17:00:10 GMT, Kevin Rushforth wrote: > gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest What format is `MyTest`? Is it some relative path? - PR: https://git.openjdk.java.net/jfx/pull/43

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v3]

2020-09-01 Thread yosbits
On Tue, 1 Sep 2020 14:12:15 GMT, Jeanette Winzenburg wrote: >> Since there was a problem that the cell was not updated when the window was >> maximized, I added a fix to >> TreeTableViewSkin.java. >> Added test code (BigTreeTableViewTest) for TreeTableView to the first post. >> >> @kleopatra

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Kevin Rushforth
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary wrote: >> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due >> to which shadow was getting drawn on top of >> actual image. apply given composite operator to graphics context before >> drawing image to fix this

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-01 Thread Kevin Rushforth
On Tue, 1 Sep 2020 13:49:48 GMT, Nir Lisker wrote: >> I guess you are trying a unit test in the `javafx.graphics` project? That >> won't work. It needs to be a system test in >> `tests/system/...` > > I tried several approaches. When I put it under `tests/system` and run the > tests task, I

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v3]

2020-09-01 Thread Jeanette Winzenburg
On Mon, 31 Aug 2020 19:16:31 GMT, yosbits wrote: > > > Since there was a problem that the cell was not updated when the window was > maximized, I added a fix to > TreeTableViewSkin.java. that's just the added listener to hbar properties (same as in TableViewSkin), or anything else changed?

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v8]

2020-09-01 Thread Ambarish Rapte
On Sat, 29 Aug 2020 10:40:35 GMT, Jeanette Winzenburg wrote: > What do you think? Suggestion looks promising, I shall try it and update. - PR: https://git.openjdk.java.net/jfx/pull/172

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-01 Thread Nir Lisker
On Tue, 1 Sep 2020 11:42:30 GMT, Kevin Rushforth wrote: >> I've written a simple draft for the automated test: >> >> PointLight light = new PointLight(Color.BLUE); >> light.setTranslateZ(-50); >> var box = new Box(100, 100, 1); >> var root = new Group(light,

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-01 Thread Kevin Rushforth
On Tue, 1 Sep 2020 10:54:50 GMT, Nir Lisker wrote: >> The performance tests need a standard GPLv2+classpath copyright header. I >> haven't tested them yet, but will do that >> next week. > > I've written a simple draft for the automated test: > > PointLight light = new

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v10]

2020-09-01 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-09-01 Thread Nir Lisker
On Fri, 7 Aug 2020 22:37:15 GMT, Kevin Rushforth wrote: >> Given that we don't have any automated tests for lighting (we have a couple >> that verify that we can take a snapshot and >> get the same result, but that isn't testing the lighting itself), probably >> the most we can expect is a

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-09-01 Thread John Hendrikx
The "dynamic update performance" performance issue we are seeing is a regression from JDK-8090322. In this change the Node treeShowing property was introduced. The JDK-8090322 warns in its description about: """Considerations: * This is too expensive to calculate for all nodes by

Re: RFR: 8202990: javafx webview css filter property with display scaling [v2]

2020-09-01 Thread Bhawesh Choudhary
> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due > to which shadow was getting drawn on top of > actual image. apply given composite operator to graphics context before > drawing image to fix this issue. another issue > is into WCGraphicsPrismContext.java. while