Re: RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v4]

2020-09-08 Thread yosbits
On Tue, 8 Sep 2020 20:19:13 GMT, Kevin Rushforth wrote: >> Column virtualization causes shortness of breath when scrolling a large >> stroke horizontally. >> This does not happen when stroking on the scrollbar. Looks like a potential >> problem with VirtualFlow. >> >> If you are worried about

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView [v4]

2020-09-08 Thread Kevin Rushforth
On Thu, 3 Sep 2020 07:44:55 GMT, yosbits wrote: >>> >>> >>> When the startup time is measured by eye, the impression changes depending >>> on the individual difference. >> >> my eye is a precision instrument :) Seriously, who would do such a thingy? >> Obviously, it must be measured, for

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-09-08 Thread Kevin Rushforth
On Thu, 27 Aug 2020 00:07:21 GMT, Kevin Rushforth wrote: >> So far, there are two alternative fixes for the bad performance issue while >> scrolling TableView/TreeTableViews: >> >> - this one #108, that tries to improve the performance of excessive number >> of `removeListener` calls >> - the

Re: Possible approaches to JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-09-08 Thread Kevin Rushforth
Thanks for filing it, Jose. I think it's better not to use JDK-8185886 for any of these PRs, since it's too generic a description, and was meant as an umbrella issue anyway, so I closed it as a duplicate of the 4 issues that are split out from it. I filed a new issue for each of PR #108 and

Re: RFR: 8252811: The list of cells in a VirtualFlow is cleared every time the number of items changes

2020-09-08 Thread Johan Vos
On Tue, 8 Sep 2020 11:56:51 GMT, Jose Pereda wrote: > This PR removes an old fix (RT-13965/JDK-8113318), which was applied in 2011 > to avoid a memory leak in > `VirtualFlow::sheetChildren`, after new items were constantly added. > With the current VirtualFlow implementation, there are in place

RFR: 8252811: The list of cells in a VirtualFlow is cleared every time the number of items changes

2020-09-08 Thread Jose Pereda
This PR removes an old fix (RT-13965/JDK-8113318), which was applied in 2011 to avoid a memory leak in `VirtualFlow::sheetChildren`, after new items were constantly added. With the current VirtualFlow implementation, there are in place the necessary methods that take care of cleaning or adding

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v12]

2020-09-08 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image

Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v11]

2020-09-08 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image