Integrated: 8240499: Enforce whitespace checking for additional source files

2020-09-15 Thread Kevin Rushforth
On Fri, 11 Sep 2020 13:21:29 GMT, Kevin Rushforth wrote: > The `.jcheck/conf` file is configured to check the same set of files as the > old HG jcheck, namely files with the > following extensions: > .java, .c, .h, .cpp, .hpp > > The Skara git jcheck allows us to evolve the rules for white

Re: RFR: 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec [v3]

2020-09-15 Thread Kevin Rushforth
On Tue, 15 Sep 2020 16:21:06 GMT, Nir Lisker wrote: >> Marked as reviewed by arapte (Reviewer). > > It's not really ready to be integrated, right? It's not finding the CSR I > think. Correct. It is not yet ready. [SKARA-548](https://bugs.openjdk.java.net/browse/SKARA-548) is not yet

Re: RFR: 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec [v3]

2020-09-15 Thread Nir Lisker
On Tue, 15 Sep 2020 15:57:00 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments and added > > Marked as reviewed by arapte (Reviewer). It's not really ready to be

RFR: 8253123: Switch FX build to use JDK 15 as boot JDK

2020-09-15 Thread Kevin Rushforth
Updates the boot JDK used to build JavaFX 16 to JDK 15. The minimum remains at JDK 11. Note to reviewers: the build number for JDK 15 GA is the same as JDK 14 GA, so that property is intentionally unchanged (I didn't forget to update it). - Commit messages: - 8253123: Switch FX

Re: RFR: 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec [v3]

2020-09-15 Thread Ambarish Rapte
On Sat, 12 Sep 2020 14:10:38 GMT, Nir Lisker wrote: >> Moving implementation details about lazy evaluation and equality checking to >> `@implSpec`. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review comments

Re: RFR: 8169501: GIF animation is too fast

2020-09-15 Thread Nir Lisker
On Tue, 15 Sep 2020 06:41:29 GMT, Bhawesh Choudhary wrote: >> This is pending response to comments above. > > 10ms![10ms](https://user-images.githubusercontent.com/4208131/93172831-3c9fcb80-f749-11ea-93ee-46b58ecff4c3.gif) > >

Re: RFR: 8240499: Enforce whitespace checking for additional source files

2020-09-15 Thread Ambarish Rapte
On Fri, 11 Sep 2020 13:21:29 GMT, Kevin Rushforth wrote: > The `.jcheck/conf` file is configured to check the same set of files as the > old HG jcheck, namely files with the > following extensions: > .java, .c, .h, .cpp, .hpp > > The Skara git jcheck allows us to evolve the rules for white

Re: RFR: 8252446: Screen.getScreens() is empty sometimes

2020-09-15 Thread Ambarish Rapte
On Thu, 3 Sep 2020 15:18:06 GMT, Kevin Rushforth wrote: > As noted in the bug report, we get a pair of change events every time the > list of screens changes. First, a change is > sent with an empty list of screens and then a change is sent with the new > list of screens. This happens whenever

Re: RFR: 8169501: GIF animation is too fast

2020-09-15 Thread Bhawesh Choudhary
On Thu, 23 Jul 2020 17:42:57 GMT, Kevin Rushforth wrote: >> issue is caused by the threshold value for frame duration used by javaFx >> before it gets normalized. JavaFx is using >> threshold value 10 while other browser (Safari, Firefox) is using 50 due to >> which, value between 10 and 50