On Wed, 16 Dec 2020 19:07:17 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
>
On Wed, 16 Dec 2020 19:25:56 GMT, Frederic Thevenet
wrote:
>> Looking the git blame, it appears the orignal and copy diverged on commit
>> 55cf799de20b6fbf9ee31850b75c34389c8a28f2 "Baseline offset depends on layout
>> bounds which are calculated during layout".
>> I really can't say if TextFlo
On Wed, 16 Dec 2020 19:07:17 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
>
On Wed, 16 Dec 2020 13:36:34 GMT, Johan Vos wrote:
>> Looks good to me.
>
> I will look into the iOS changes.
I confirm that the iOS changes do not cause regression.
-
PR: https://git.openjdk.java.net/jfx/pull/368
On Wed, 16 Dec 2020 18:14:42 GMT, Frederic Thevenet
wrote:
>> Region is part of the public API, so any change to increase the visibility
>> of fields or methods would require a new enhancement with a CSR and
>> justification as to why it is needed as public API. We wouldn't do that just
>> to
> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
> the java class com.sun.webkit.MainThread can be found be the JNI
> function FindClass. This is only true if the class is loadable by the
> system class loader.
>
> One such case is when the OpenJFX modules are loaded from a n
On Wed, 16 Dec 2020 18:52:22 GMT, Matthias Bläsing
wrote:
>> tests/system/src/testapp7/java/mymod/myapp7/DataUrlWithModuleLayerLauncher.java
>> line 44:
>>
>>> 42: new Thread() {
>>> 43: {
>>> 44: setDaemon(true);
>>
>> Ordinarily a good idea, but in this c
On Wed, 16 Dec 2020 18:43:33 GMT, Kevin Rushforth wrote:
>> Matthias Bläsing has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ensure that the process sentinal does not keep the JVM running
>
> tests/system/src/testapp7/java/mymod/myapp7/D
On Wed, 16 Dec 2020 18:30:13 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
>
> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
> the java class com.sun.webkit.MainThread can be found be the JNI
> function FindClass. This is only true if the class is loadable by the
> system class loader.
>
> One such case is when the OpenJFX modules are loaded from a n
> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
> the java class com.sun.webkit.MainThread can be found be the JNI
> function FindClass. This is only true if the class is loadable by the
> system class loader.
>
> One such case is when the OpenJFX modules are loaded from a n
> This PR aims to fix the blurriness to sometimes affects some controls (such
> as TextArea) in a scene when rendered with a scaling factor that is not an
> integer (typically when viewed on a HiDPI screen with a 125%, 150% or 175%
> output scaling).
>
> Please note that regardless of what the
On Wed, 16 Dec 2020 17:24:10 GMT, Kevin Rushforth wrote:
>>>
>>>
>>> Good catch. Yes, `TextFlow` has the same problem, and ought to be fixed as
>>> part of this, probably by deleting that method and using the public methods
>>> in Region. It seems wholly unnecessary to use the copied method,
On Wed, 16 Dec 2020 17:13:57 GMT, Frederic Thevenet
wrote:
>> Good catch. Yes, `TextFlow` has the same problem, and ought to be fixed as
>> part of this, probably by deleting that method and using the public methods
>> in Region. It seems wholly unnecessary to use the copied method, since the
On Wed, 16 Dec 2020 16:39:37 GMT, Kevin Rushforth wrote:
>
>
> Good catch. Yes, `TextFlow` has the same problem, and ought to be fixed as
> part of this, probably by deleting that method and using the public methods
> in Region. It seems wholly unnecessary to use the copied method, since the
On Wed, 16 Dec 2020 15:33:36 GMT, Frederic Thevenet
wrote:
>> That file was modified earlier in the year without the copyright year being
>> updated, so it will be updated by a script when @arapte implements
>> [JDK-8254101](https://bugs.openjdk.java.net/browse/JDK-8254101) early next
>> week
On Tue, 15 Dec 2020 16:57:13 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
>
On Wed, 16 Dec 2020 13:36:27 GMT, Kevin Rushforth wrote:
>> I was thinking, while I'm at it I might as well update the copyright notice
>> for Region.java; should it be 2020 or 2021 (or left alone)?
>
> That file was modified earlier in the year without the copyright year being
> updated, so it
On Tue, 15 Dec 2020 22:51:33 GMT, Kevin Rushforth wrote:
>> Matthias Bläsing has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated according to review comments
>>
>> - The text and formatting was adjusted according to the raised c
On Wed, 16 Dec 2020 13:36:13 GMT, Ambarish Rapte wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Respond to feedback: change masterWindow to mainWindow in iOS files
>
> Looks good to me.
I will look into the iO
On Wed, 16 Dec 2020 13:20:23 GMT, Kevin Rushforth wrote:
>> Replace archaic/non-inclusive words in JavaFX with more neutral terms. See
>> [JDK-8253315](https://bugs.openjdk.java.net/browse/JDK-8253315) for
>> background information.
>>
>> The following changes are made:
>>
>> 1. Rename whitel
On Wed, 16 Dec 2020 13:24:25 GMT, Frederic Thevenet
wrote:
>> I agree that it is better to separate the scrollpane issue from the cache
>> rendering one.
>>
>> I've reverted my initial changes and applied the changes you proposed (using
>> snapSpaceX/Y as suggested in your latest comment).
>
On Wed, 16 Dec 2020 12:55:49 GMT, Frederic Thevenet
wrote:
>> In looking at the other instances where snap-to-pixel is done correctly for
>> Insets, the above should use `snapSpace{X,Y}` rather than `snapSize{X,Y}`
>
> I agree that it is better to separate the scrollpane issue from the cache
>
On Wed, 16 Dec 2020 13:17:01 GMT, Kevin Rushforth wrote:
>> `modules\javafx.graphics\src\main\native-glass\ios\GlassWindow.h` has
>> declaration of variables named `masterWindow` and `masterWindowHost`.
>> Please check if we should change these too.
>
> Yes, I agree that these should be changed
On Wed, 16 Dec 2020 12:35:34 GMT, Ambarish Rapte wrote:
>> Replace archaic/non-inclusive words in JavaFX with more neutral terms. See
>> [JDK-8253315](https://bugs.openjdk.java.net/browse/JDK-8253315) for
>> background information.
>>
>> The following changes are made:
>>
>> 1. Rename whiteli
> Replace archaic/non-inclusive words in JavaFX with more neutral terms. See
> [JDK-8253315](https://bugs.openjdk.java.net/browse/JDK-8253315) for
> background information.
>
> The following changes are made:
>
> 1. Rename whitelist/blacklist to allowlist/rejectlist
> 2. Rename `MasterTimer` to
On Wed, 16 Dec 2020 00:42:24 GMT, Kevin Rushforth wrote:
>> For completeness, here is the patch for the snap-to-pixel issue:
>>
>> diff --git
>> a/modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java
>> b/modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java
>>
> This PR aims to fix the blurriness to sometimes affects some controls (such
> as TextArea) in a scene when rendered with a scaling factor that is not an
> integer (typically when viewed on a HiDPI screen with a 125%, 150% or 175%
> output scaling).
>
> Please note that regardless of what the
On Tue, 15 Dec 2020 13:03:53 GMT, Kevin Rushforth wrote:
> Replace archaic/non-inclusive words in JavaFX with more neutral terms. See
> [JDK-8253315](https://bugs.openjdk.java.net/browse/JDK-8253315) for
> background information.
>
> The following changes are made:
>
> 1. Rename whitelist/bla
29 matches
Mail list logo
