Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-21 Thread Kevin Rushforth
On Thu, 21 Jan 2021 06:42:19 GMT, Robert Lichtenberger wrote: > By using the anchor location facility of PopupWindows we can avoid > miscalculation of the > menu's height entirely. > This fix also cleans up some documentation issues. > This fix introduces tests that check the correct

Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]

2021-01-21 Thread Kevin Rushforth
On Thu, 21 Jan 2021 19:11:21 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix color in DefaultPlugin > > Looks good. Build + automated tests passed on all three platforms. I ran into > one

Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]

2021-01-21 Thread Kevin Rushforth
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote: >> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Fix color in DefaultPlugin Looks good. Build + automated tests passed

Re: RFR: 8259635: Update to 610.2 version of WebKit

2021-01-21 Thread Johan Vos
On Thu, 21 Jan 2021 14:05:54 GMT, Arun Joseph wrote: >> I reviewed all of the changes outside `modules/javafx.web/src/main/native/`. >> Most look related to the change to use the Prism Color object instead of an >> int. I did have a question about one of those changes: >> >>

Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]

2021-01-21 Thread Arun Joseph
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Fix color in DefaultPlugin - Changes: - all: https://git.openjdk.java.net/jfx/pull/382/files - new:

Re: RFR: 8259635: Update to 610.2 version of WebKit

2021-01-21 Thread Arun Joseph
On Thu, 21 Jan 2021 13:25:39 GMT, Kevin Rushforth wrote: >> Update JavaFX WebKit to GTK WebKit 2.30 (610.2) > > I reviewed all of the changes outside `modules/javafx.web/src/main/native/`. > Most look related to the change to use the Prism Color object instead of an > int. I did have a

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-21 Thread Johan Vos
On Thu, 21 Jan 2021 12:47:01 GMT, Kevin Rushforth wrote: >> By using the anchor location facility of PopupWindows we can avoid >> miscalculation of the >> menu's height entirely. >> This fix also cleans up some documentation issues. >> This fix introduces tests that check the correct

Re: RFR: 8259635: Update to 610.2 version of WebKit

2021-01-21 Thread Kevin Rushforth
On Thu, 21 Jan 2021 04:14:28 GMT, Arun Joseph wrote: > Update JavaFX WebKit to GTK WebKit 2.30 (610.2) I reviewed all of the changes outside `modules/javafx.web/src/main/native/`. Most look related to the change to use the Prism Color object instead of an int. I did have a question about one

Re: Re: cleanup obsolete code

2021-01-21 Thread Eric Bresie
Would removal of this break anything on other platforms (OS or hardware [embedded/non-embedded], Wayland)? Assume since focused x11 (mainly Unix platforms) it shouldn’t but figured I’d ask. A little off topic but is an architecture diagram with applicable elements available someplace? If not

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-21 Thread Kevin Rushforth
On Thu, 21 Jan 2021 06:42:19 GMT, Robert Lichtenberger wrote: > By using the anchor location facility of PopupWindows we can avoid > miscalculation of the > menu's height entirely. > This fix also cleans up some documentation issues. > This fix introduces tests that check the correct