RFR: 8258986: getColor throws IOOBE when PixelReader reads the same pixel twice

2021-01-28 Thread Kevin Rushforth
As indicated in the JBS bug, using a `PixelReader` to read a scaled image in HiDPI mode, for example an `@2x` image, to read more than one pixel will read data from the wrong location in the image, usually leading to an IOOBE. The bug is in the `getPixelAccessor` method of Prism Image. The

JavaFX 16 is in Rampdown Phase Two (RDP2)

2021-01-28 Thread Kevin Rushforth
To: OpenJFX Developers As a reminder, JavaFX 16 is now in Rampdown Phase Two (RDP2). [1] P1-P2 bugs, and test or doc bugs of any priority, can be fixed during RDP2. Explicit approval is needed for bug fixes (except for doc and test fixes), and all enhancements to go in to the jfx16 branch.

Re: RFR: 8252935: Add treeShowing listener only when needed [v3]

2021-01-28 Thread Kevin Rushforth
On Sun, 24 Jan 2021 15:25:06 GMT, John Hendrikx wrote: >> This is a PoC for performance testing. >> >> It contains commented out code in PopupWindow and ProgressIndicatorSkin and >> two tests are failing because of that. >> >> This code avoids registering two listeners (on Scene and on

Re: RFR: 8256283: IndexOutOfBoundsException when sorting a TreeTableView [v2]

2021-01-28 Thread Ambarish Rapte
On Fri, 22 Jan 2021 17:48:15 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review correction > > modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java > line 582:

Re: RFR: 8256283: IndexOutOfBoundsException when sorting a TreeTableView [v2]

2021-01-28 Thread Ambarish Rapte
> This particular issue JDK-8256283, is a specific case of IOOBE when, rootItem > is not shown, some children including first child are selected, then all > children are removed and sort() is invoked. The sort() fails with an IOOBE. > This PR only addresses this specific IOOBE. > Root cause of