Re: RFR: 8204568: Relative CSS-Attributes don't work all time

2021-02-08 Thread Kevin Rushforth
On Mon, 8 Feb 2021 11:37:35 GMT, Ambarish Rapte wrote: > Issue is that the size of properties that are relatively(`em`) sized is not > computed correctly when the reference `-fx-font-size` is also specified > relatively and is nested. > > Fix is a slight variation of an earlier suggestion in

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v7]

2021-02-08 Thread Nir Lisker
On Wed, 3 Feb 2021 21:56:08 GMT, Kevin Rushforth wrote: > I still get a runtime shader compilation error on Mac (see above) I pushed a fix now. Since it doesn't happen on Win or Ubuntu I can't verify it, but I changed `0` to `0.0` etc. in the shader code. > Unless the transform itself is

Re: RFR: 8259046: ViewPainter.ROOT_PATHS holds reference to Scene causing memory leak

2021-02-08 Thread Ambarish Rapte
On Wed, 27 Jan 2021 13:31:45 GMT, Kevin Rushforth wrote: > Prism implements a dirty region optimization, where in many cases, only part > of the scene graph is re-rendered when something changes. In support of this, > the `ViewPainter` class in the Quantum Toolkit keeps an array of node paths,

Re: RFR: 8204568: Relative CSS-Attributes don't work all time

2021-02-08 Thread David Grieve
On Mon, 8 Feb 2021 11:37:35 GMT, Ambarish Rapte wrote: > Issue is that the size of properties that are relatively(`em`) sized is not > computed correctly when the reference `-fx-font-size` is also specified > relatively and is nested. > > Fix is a slight variation of an earlier suggestion in

Re: RFR: 8252935: Add treeShowing listener only when needed [v4]

2021-02-08 Thread Ambarish Rapte
On Sat, 6 Feb 2021 18:17:40 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java >> line 89: >> >>> 87: >>> NodeHelper.treeVisibleProperty(node).addListener(windowShowingChangedListener); >>> 88: >>> 89:

RFR: 8204568: Relative CSS-Attributes don't work all time

2021-02-08 Thread Ambarish Rapte
Issue is that the size of properties that are relatively(`em`) sized is not computed correctly when the reference `-fx-font-size` is also specified relatively and is nested. Fix is a slight variation of an earlier suggestion in [the PR](https://github.com/javafxports/openjdk-jfx/pull/94). Fix

Re: RFR: 8259046: ViewPainter.ROOT_PATHS holds reference to Scene causing memory leak

2021-02-08 Thread Pankaj Bansal
On Wed, 27 Jan 2021 13:31:45 GMT, Kevin Rushforth wrote: > Prism implements a dirty region optimization, where in many cases, only part > of the scene graph is re-rendered when something changes. In support of this, > the `ViewPainter` class in the Quantum Toolkit keeps an array of node paths,