Re: RFR: 8089913: CSS styling problem with Slider pseudo classes

On Wed, 3 Mar 2021 16:40:27 GMT, Jeanette Winzenburg wrote: >> @mstr2 can you enable pre-submit testing for your repo as indicated the >> Checks section? You might need to then push a new (empty) commit to your >> branch in order to trigger the tests to run. > > side note: there might be a sim

Re: RFR: 8262802: Wrong context origin coordinates when using EGL and HiDPI [v2]

On Wed, 3 Mar 2021 23:04:01 GMT, Jose Pereda wrote: >> See [issue](https://bugs.openjdk.java.net/browse/JDK-8262802) for detailed >> description. >> >> This PR solves the wrong calculations of ContextX and ContextY in >> ES2SwapChain when EGL is used on HiDPI devices, by using properly scaled

Re: RFR: 8204568: Relative CSS-Attributes don't work all time [v2]

On Thu, 4 Mar 2021 04:01:03 GMT, Ambarish Rapte wrote: >> Issue is that the size of properties that are relatively(`em`) sized is not >> computed correctly when the reference `-fx-font-size` is also specified >> relatively and is nested. >> >> Fix is a slight variation of an earlier suggestion

Re: RFR: WIP: 8260528: Clean glass-gtk sizing and positioning code [v20]

> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > > C

Re: Eclipse problem: not compiling module projects

I updated to the December version (4.18) a while ago and didn't have any issues. Maybe there was some new compiler setting that did something, so I would look at the release notes. I'm going to move to 4.19 soon. On Tue, Mar 2, 2021 at 3:48 PM Jeanette Winzenburg wrote: > > "from scratch" are th

Integrated: Merge jfx:jfx16

Sync `jfx16` branch into `master`. - Commit messages: - Merge branch 'jfx16' into merge-jfx16-2021-03-04 - 8260165: CSSFilterTest.testCSSFilterRendering system test fails - 8260257: [Linux] WebView no longer reacts to some mouse events - 8262236: Configure Gradle checksum verifica

Integrated: Merge jfx:jfx16

On Thu, 4 Mar 2021 12:36:29 GMT, Kevin Rushforth wrote: > Sync `jfx16` branch into `master`. This pull request has now been integrated. Changeset: a00ef79c Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/a00ef79c Stats: 92 lines in 1 file changed: 92 ins; 0 de

[jfx16] Integrated: 8262460: Create release notes for JavaFX 16

On Tue, 2 Mar 2021 18:25:14 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 16 to the repository This pull request has now been integrated. Changeset: e0ce73a3 Author:Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/e0ce73a3 Stats: 92

Re: RFR: WIP: 8260528: Clean glass-gtk sizing and positioning code [v19]

> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > > C

RFR: 8262276: Debug build of WebKit fails

Fixing the Debug build of WebKit. Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test using a simple HelloWebView app. - Commit messages: - 8262276: Debug build of WebKit fails Changes: https://git.openjdk.java.net/jfx/pull/417/files Webrev: https://webre

Re: RFR: 8204568: Relative CSS-Attributes don't work all time [v2]

On Tue, 9 Feb 2021 01:33:06 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update to recalculate properties when font size changes > > This is taking me longer to review than I expected, bec