Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z)

2021-03-16 Thread Martin Fox
On Tue, 16 Mar 2021 11:13:39 GMT, Tom Schindl wrote: >> On the French keyboard the digits are shifted but I assumed we would still >> want those keys to map to KeyCode.0-9 as they do on Windows. My solution was >> to hard-code those key positions to be digits but this interferes with >>

Re: RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-16 Thread Johan Vos
On Tue, 16 Mar 2021 16:30:51 GMT, Kevin Rushforth wrote: > We currently hard-code the default version of Visual Studio in both > `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the > specific version of MSVC is fragile, particularly for GitHub action builds. > The last

RFR: 8255713: JavaFX build should discover Visual Studio compiler on system

2021-03-16 Thread Kevin Rushforth
We currently hard-code the default version of Visual Studio in both `win.gradle` and `.github/workflows/submit.yml`. This hard-coding of the specific version of MSVC is fragile, particularly for GitHub action builds. The last time Microsoft changed the environment, our Windows builds started

RFR: 8092439: [Monocle] Refactor monocle SPI to allow support for multiple screens

2021-03-16 Thread Johan Vos
Fix for JDK-8092439 and JDK-8092064 Monocle currently hard-codes a single Screen, and the `staticScreen_getScreens()` method will never return more than 1 Screen. This PR introduces the possibility to deal with multiple screens, which is not uncommon on embedded systems. By default, the

Re: [External] : Re: OpenJFX custom build - Java application crash (semi-related to 8262276)

2021-03-16 Thread Arun Joseph
The app is now crashing at InternalFunction which calls jsDynamicCast in JSCast.h, which lead to the initial crash. This assert failure occurs because the type value is ObjectType instead of InternalFunctionType or NullSetterFunctionType. I need to check why this is happens. NDEBUG and

ToggleGroup does not manage its toggles

2021-03-16 Thread Hannes H.
Hello, while discussing a question on StackOverflow, I learned that a ToggleGroup actually does not manage its toggles, but the toggles are responsible to ensure that only one of them is selected at a time. This topic came up because I want to apply exactly the same behavior of RadioMenuItems in

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z)

2021-03-16 Thread Tom Schindl
On Mon, 15 Mar 2021 21:40:55 GMT, Martin Fox wrote: >> https://github.com/openjdk/jdk/blob/8760688d213865eaf1bd675056eb809cdae67048/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m#L462 > > On the French keyboard the digits are shifted but I assumed we would still > want those keys