Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-17 Thread John Neffenger
On Sat, 17 Apr 2021 23:17:04 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure Gr

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-17 Thread John Neffenger
> This pull request adds dependency verification to the Gradle builds of JavaFX > on Linux, macOS, and Windows. It is the third of three changes that close the > gaps in the JavaFX build security: > > * [JDK-8262236][1]: Configure Gradle checksum verification > * [JDK-8263204][2]: Add Gradle Wra

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v13]

2021-04-17 Thread Nir Lisker
On Fri, 9 Apr 2021 20:50:55 GMT, Kevin Rushforth wrote: >> I will check the range issue on (non-VM) Linux. I don't have a Mac, so not >> sure what to do if Linux checks out. >> >>> As for setting the spot light direction using rotation, I think there are >>> three API choices, and I don't like

Re: RFR: 8264010: Add Gradle dependency verification [v3]

2021-04-17 Thread Kevin Rushforth
On Wed, 14 Apr 2021 04:32:29 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure Gr

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v3]

2021-04-17 Thread John Neffenger
On Sun, 4 Apr 2021 16:36:27 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $ export

Re: RFR: 8259356: MediaPlayer's seek freezes video

2021-04-17 Thread Johan Vos
On Sat, 17 Apr 2021 01:39:17 GMT, Alexander Matveev wrote: > This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS > streams (unfortunately I was not able to find repro case and more details on > why it was added) in gstappsink.c line 659-678 to store current caps which

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v10]

2021-04-17 Thread Kevin Rushforth
On Sat, 17 Apr 2021 13:48:23 GMT, Jeanette Winzenburg wrote: >> Changes in Lambda..Handler: >> - added api and implemenation to support invalidation and listChange >> listeners in the same way as changeListeners >> - added java doc >> - added tests >> >> Changes in SkinBase >> - added api (an

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v9]

2021-04-17 Thread Kevin Rushforth
On Sat, 17 Apr 2021 13:44:07 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/LambdaMultipleHandlerTest.java >> line 211: >> >>> 209: WeakReference ref >>> = >>> 210: new WeakReference<>(new >>> LambdaMultipleP

Re: RFR: 8259356: MediaPlayer's seek freezes video

2021-04-17 Thread Kevin Rushforth
On Sat, 17 Apr 2021 01:39:17 GMT, Alexander Matveev wrote: > This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS > streams (unfortunately I was not able to find repro case and more details on > why it was added) in gstappsink.c line 659-678 to store current caps which

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v10]

2021-04-17 Thread Jeanette Winzenburg
> Changes in Lambda..Handler: > - added api and implemenation to support invalidation and listChange > listeners in the same way as changeListeners > - added java doc > - added tests > > Changes in SkinBase > - added api (and implementation delegating to the handler) > - copied java doc from the

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v9]

2021-04-17 Thread Jeanette Winzenburg
On Thu, 15 Apr 2021 12:57:30 GMT, Kevin Rushforth wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed description as suggested in review > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/con

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-17 Thread Johan Vos
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH a