Re: Unable to import OpenJFX Build into Eclipse

2021-04-20 Thread Robert Lichtenberger
I have tried to import OpenJFX to eclipse under Windows today for the first time and having the exakt same problem. Am Mo., 17. Aug. 2020 um 13:52 Uhr schrieb Nir Lisker : > They are not required if you use the command line interface, but I find > that they do make things easier since I can run

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v5]

2021-04-20 Thread Ambarish Rapte
On Sun, 11 Apr 2021 15:48:11 GMT, Florian Kirmaier wrote: >> Fixing a memory leak. >> A node hard references its old parent after CSS layout and getting removed. >> This shouldn't be the case, this is very counterintuitive. >> >> The fix uses a WeakReference in CSSStyleHelper for

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v14]

2021-04-20 Thread Kevin Rushforth
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with

Re: RFR: 8262276: Debug build of WebKit fails [v3]

2021-04-20 Thread Arun Joseph
> Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Arun Joseph has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: -

Integrated: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread Arun Joseph
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. This pull request has now been integrated. Changeset: 49d2126e Author:Arun

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread Guru Hb
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. Looks good to me . Tested on Windows with Modified WebView which loads multiple

Integrated: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-20 Thread Robert Lichtenberger
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. This pull request has now been integrated.

Integrated: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

2021-04-20 Thread Ajit Ghaisas
On Mon, 19 Apr 2021 12:51:06 GMT, Ajit Ghaisas wrote: > This PR enables ignored unit tests from MenuItemTest and fixes them. > 4 ignored tests are fixed. > 2 ignored tests are removed. > > > **Before fix :** > total tests = 89 > failures = 0 > ignored tests = 6 > > **After fix :** > total

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-20 Thread Kevin Rushforth
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. Marked as reviewed by kcr (Lead). Thank you for

Re: Local test failure of LocalDateTimeStringConverterTest.testChronologyConsistency

2021-04-20 Thread Jeanette Winzenburg
added a comment to Ajit's issue, thanks :) Zitat von Kevin Rushforth : Looks like you've discovered another Locale-sensitive test, similar to the one Ajit is working on now: https://bugs.openjdk.java.net/browse/JDK-8264952 We could either file a new bug or expand JDK-8264952 to include

Re: Local test failure of LocalDateTimeStringConverterTest.testChronologyConsistency

2021-04-20 Thread Kevin Rushforth
Looks like you've discovered another Locale-sensitive test, similar to the one Ajit is working on now: https://bugs.openjdk.java.net/browse/JDK-8264952 We could either file a new bug or expand JDK-8264952 to include this one. I'd probably recommend the latter, since it is in the same general

Re: RFR: 8265513: Openjfx graphics build broken (Eclipse)

2021-04-20 Thread Nir Lisker
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg wrote: > Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in > [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330). > > Fix is to add-exports in Eclipse .classpath in graphics (same as done for > controls

Local test failure of LocalDateTimeStringConverterTest.testChronologyConsistency

2021-04-20 Thread Jeanette Winzenburg
the top of the failure trace: org.junit.ComparisonFailure: expected:<...y, January 12, 60 Sh[ō]wa, 12:34:56 PM> but was:<...y, January 12, 60 Sh[o]wa, 12:34:56 PM> at org.junit.Assert.assertEquals(Assert.java:123) at org.junit.Assert.assertEquals(Assert.java:145) at

Re: RFR: 8265513: Openjfx graphics build broken (Eclipse)

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg wrote: > Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in > [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330). > > Fix is to add-exports in Eclipse .classpath in graphics (same as done for > controls

Re: RFR: 8234084: [TEST_BUG] Remove unexecuted performance benchmark tests

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 09:12:40 GMT, Ambarish Rapte wrote: > This PR removes two benchmark tests that are ignored since they were added > [here](https://github.com/openjdk/jfx/commit/0dea6d6790ae4eeff3e5ec5a7750251caf91e40b) > > test.javafx.scene.input.TouchEventTest.saneOrderingBenchmark >

Re: RFR: 8234077: Evaluate ignored unit tests in RenderRootTest [v2]

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 07:45:33 GMT, Ambarish Rapte wrote: >> These are 2 corner case test cases for getRenderRoot() method. >> 1. `emptyDirtyRegion():` When the dirty region rect is empty i.e. (0, 0, -1, >> -1) >> 2. `zeroSizeDirtyRegionWithinOpaqueRegion()`: When the dirty region rect is >> of

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest [v2]

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 05:45:47 GMT, Ajit Ghaisas wrote: >> This PR enables ignored unit tests from MenuItemTest and fixes them. >> 4 ignored tests are fixed. >> 2 ignored tests are removed. >> >> >> **Before fix :** >> total tests = 89 >> failures = 0 >> ignored tests = 6 >> >> **After fix

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 10:31:59 GMT, PrimosK wrote: >> Issue: Java application (with WebView) will completely freeze after using it >> for a while. >> >> Fix: Use native isMainThread functions instead of JNI call. > > We've created another production build and it seems to be working fine! >

RFR: 8265513: Openjfx graphics build broken (Eclipse)

2021-04-20 Thread Jeanette Winzenburg
Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330). Fix is to add-exports in Eclipse .classpath in graphics (same as done for controls in fix of [JDK-8256184](https://bugs.openjdk.java.net/browse/JDK-8256184)

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread PrimosK
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. We've created another production build and it seems to be working fine!

RFR: 8234084: [TEST_BUG] Remove unexecuted performance benchmark tests

2021-04-20 Thread Ambarish Rapte
This PR removes two benchmark tests that are ignored since they were added [here](https://github.com/openjdk/jfx/commit/0dea6d6790ae4eeff3e5ec5a7750251caf91e40b) test.javafx.scene.input.TouchEventTest.saneOrderingBenchmark test.javafx.scene.input.TouchEventTest.crazyOrderingBenchmark Since the

Re: AArch64 naming conventions

2021-04-20 Thread Johan Vos
I'd like to go even further: OpenJDK has a make/autoconf/platform.m4 file which specifies the possible values for CPU_ARCH etc. This allows to uniquely define OPENJDK_BUILD_CPU_ARCH and OPENJDK_TARGET_CPU_ARCH. If we did something similar (in build.gradle), we would be able to be more consistent

Re: RFR: 8234077: Evaluate ignored unit tests in RenderRootTest [v2]

2021-04-20 Thread Ambarish Rapte
> These are 2 corner case test cases for getRenderRoot() method. > 1. `emptyDirtyRegion():` When the dirty region rect is empty i.e. (0, 0, -1, > -1) > 2. `zeroSizeDirtyRegionWithinOpaqueRegion()`: When the dirty region rect is > of zero dimensions, for example (20, 20, 0, 0) > > -

Re: RFR: 8234077: Evaluate ignored unit tests in RenderRootTest

2021-04-20 Thread Ambarish Rapte
On Fri, 16 Apr 2021 22:29:04 GMT, Kevin Rushforth wrote: > Yes, filing a new bug to evaluate case 1 seems like the best option Thanks for the comment, I have created a new JBS issue and updated id in the ignore tags. - PR: https://git.openjdk.java.net/jfx/pull/463

Re: RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v4]

2021-04-20 Thread Johan Vos
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy wrote: >> This is a proposal for cross compiling JavaFX base modules (excluding media >> and webkit) for Windows AArch64 (ARM64). >> >> Main changes: >> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition >> - HOST_ARCH

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-20 Thread Robert Lichtenberger
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. I've finally managed to build JavaFX under

Re: javafx-swt not deployed on maven central

2021-04-20 Thread Tom Schindl
Hi, So I deployed the Artifact in the meanwhile to our companies public maven repo [1] as I didn't want to pollute maven-central with javafx-swt in a different namespace. Tom [1] https://maven.bestsolution.at/releases/at/bestsolution/openjfx/javafx-swt/ Am 07.04.21 um 10:53 schrieb Tom