Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v4]

2021-04-25 Thread mstr2
> This PR fixes the implementation of `ControlUtils.reducingChange`, which > incorrectly computed adjacent removed indices, thus resulting in incorrect > removal notifications. > > Since there were no unit tests for this method, I also added a bunch of tests. > > After applying this fix, I can

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v3]

2021-04-25 Thread mstr2
On Sun, 25 Apr 2021 15:35:58 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v3]

2021-04-25 Thread mstr2
> This PR fixes the implementation of `ControlUtils.reducingChange`, which > incorrectly computed adjacent removed indices, thus resulting in incorrect > removal notifications. > > Since there were no unit tests for this method, I also added a bunch of tests. > > After applying this fix, I can

Re: Convenience factories for Border and Background

2021-04-25 Thread Nir Lisker
> > I think a minimal constructor would be a nice first step. I want to avoid adding more constructors, so factory methods would be my go-to. We may can go further from that and create something similar like the > BorderFactory A factory class or a builder require a whole new class and

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v2]

2021-04-25 Thread Jeanette Winzenburg
On Sat, 24 Apr 2021 20:55:52 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also