Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-26 Thread Alexander Matveev
On Sat, 24 Apr 2021 02:23:19 GMT, Alexander Matveev wrote: > Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > default device

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

2021-04-26 Thread Alexander Matveev
> Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > default device is not restored until user logs back to computer. So, after

Re: Monocle, headless isolated from embedded

2021-04-26 Thread John Neffenger
On 4/21/21 12:06 PM, Johan Vos wrote: However, I don't think Monocle is ready at this moment to be bundled with the desktop releases. Serious question: Why not? If we do move the Headless Platform out of Monocle, we should consider bringing its VNC Platform subclass along as well. John

Re: Convenience factories for Border and Background

2021-04-26 Thread Kevin Rushforth
I would lean towards the simpler solution that Nir has proposed. I would like to be informed by what application developers want. -- Kevin On 4/26/2021 2:03 PM, Marius Hanl wrote: I'm fine with either way. Both approaches are nice, while the factory/builder approach will probably

Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]

2021-04-26 Thread Kevin Rushforth
On Mon, 26 Apr 2021 13:14:20 GMT, Jonathan Vusich wrote: >> modules/javafx.controls/src/main/java/javafx/scene/chart/CategoryAxis.java >> line 365: >> >>> 363: double requiredLengthToDisplay = >>> calculateRequiredSize(side.isVertical(), tickLabelRotation); >>> 364:

Re: Re: Convenience factories for Border and Background

2021-04-26 Thread Marius Hanl
I'm fine with either way. Both approaches are nice, while the factory/builder approach will probably be a bit better as it will cover more use cases, but of course takes a bit more time. In any case we can create a Border/Background very easily and both are quite short, the

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-26 Thread Jose Pereda
On Fri, 19 Feb 2021 14:19:35 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. > > To reproduce the issue run the > [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) > with Monocle: >> sudo

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-26 Thread Jose Pereda
On Mon, 26 Apr 2021 08:55:12 GMT, Johan Vos wrote: >> The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. >> >> To reproduce the issue run the >> [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) >> with Monocle: >>> sudo

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-26 Thread Jose Pereda
On Fri, 19 Feb 2021 14:19:35 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. > > To reproduce the issue run the > [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) > with Monocle: >> sudo

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v3]

2021-04-26 Thread mstr2
> The documentation for `ObservableListBase.nextRemove` states that a single > change always refers to the current state of the list, which likely means > that multiple disjoint removed ranges need to be applied in order, otherwise > the next change's `getFrom` doesn't refer to the correct

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-26 Thread Kevin Rushforth
On Sat, 24 Apr 2021 02:23:19 GMT, Alexander Matveev wrote: > Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > default device

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-26 Thread Kevin Rushforth
On Sat, 24 Apr 2021 02:23:19 GMT, Alexander Matveev wrote: > Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > default device

Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v7]

2021-04-26 Thread Jonathan Vusich
> As noted in the corresponding JBS issue, `Axis` does not properly compute its > preferred height when `autoRanging` is turned off. The simplest fix seems to > be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees > if there is not enough room for the category labels to

Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]

2021-04-26 Thread Jonathan Vusich
On Fri, 23 Apr 2021 23:28:49 GMT, Kevin Rushforth wrote: >> Jonathan Vusich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add tests for vertical axis as well >> - Improve layout calculations for rotated text > >

Re: RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false [v4]

2021-04-26 Thread Ambarish Rapte
On Fri, 23 Apr 2021 16:25:48 GMT, Florian Kirmaier wrote: >> Fixing leak in ProgressIndicator when treeShowing is false > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264677 > Readded countdownlatch for onShown

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v6]

2021-04-26 Thread Jeanette Winzenburg
On Mon, 26 Apr 2021 11:24:40 GMT, Jeanette Winzenburg wrote: >> I guess it doesn't make sense. Probably missunderstanding somewhere. Should >> i remove? This would also get rid of the if in the test. > > yes, remove it: the focus of this issue is that the cell sync's its own > editing state

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v6]

2021-04-26 Thread Jeanette Winzenburg
On Fri, 23 Apr 2021 16:52:14 GMT, Florian Kirmaier wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java >> line 867: >> >>> 865: @Test >>> 866: public void testChangeIndexToEditing3_jdk_8264127() { >>> 867: assertChangeIndexToEditing(1,

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v8]

2021-04-26 Thread Jeanette Winzenburg
On Fri, 23 Apr 2021 17:06:54 GMT, Florian Kirmaier wrote: >> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264127: > Added missing test

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-26 Thread Johan Vos
On Fri, 19 Feb 2021 14:19:35 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. > > To reproduce the issue run the > [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) > with Monocle: >> sudo

Integrated: 8265669: AccumCell should not be visible

2021-04-26 Thread Johan Vos
On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote: > Hide accumCell when the cell is released. > Fix for JDK-8265669 This pull request has now been integrated. Changeset: 6b63bf5c Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/6b63bf5c Stats: 13 lines in 2 files

Re: RFR: 8265669: AccumCell should not be visible

2021-04-26 Thread Ajit Ghaisas
On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote: > Hide accumCell when the cell is released. > Fix for JDK-8265669 Marked as reviewed by aghaisas (Reviewer). Thanks for the detailed answers. - PR: https://git.openjdk.java.net/jfx/pull/474