Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Integrated: 8265399: Update to Visual Studio 2019 version 16.9.3

2021-04-30 Thread Kevin Rushforth
On Tue, 27 Apr 2021 21:33:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2019 version 16.9.3 on > Windows, in order to match JDK 17 -- see > [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). > > I ran a full build and test, including media and

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-30 Thread Joeri Sykora
On Thu, 29 Apr 2021 13:17:07 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on >> Windows, in order to match JDK 17 -- see >> [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). >> >> I ran a full build and test, including

Integrated: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-30 Thread mstr2
On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 wrote: > This PR fixes incorrect parsing of mnemonic symbols in the following cases: > 1. an escaped double underscore incorrectly shows up as a double underscore > in displayed text > 2. an extended mnemonic incorrectly removes a part of adjacent text >

Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]

2021-04-30 Thread Jonathan Vusich
On Mon, 26 Apr 2021 21:06:41 GMT, Kevin Rushforth wrote: >> Well, it's complicated. The algorithm that calculates the required space for >> the tick labels does not take into account the tick label rotation. I did >> not look into adding this at this time because that opens up a lot of other

Re: RFR: 8264998: Empty Jars shouldn't have Automatic-Module-Name

2021-04-30 Thread Johan Vos
On Fri, 30 Apr 2021 08:42:14 GMT, Abhinay Agarwal wrote: > 8264998: Empty Jars shouldn't have Automatic-Module-Name Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/484

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH [v2]

2021-04-30 Thread Kevin Rushforth
On Fri, 30 Apr 2021 00:10:30 GMT, John Neffenger wrote: >> This is a continuation of the [pull request][1] started by @bmwiedemann in >> January 2020. After this change is integrated, I can follow up immediately >> with additional pull requests that get us much closer to providing fully >>

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-30 Thread Kevin Rushforth
On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 wrote: > This PR fixes incorrect parsing of mnemonic symbols in the following cases: > 1. an escaped double underscore incorrectly shows up as a double underscore > in displayed text > 2. an extended mnemonic incorrectly removes a part of adjacent text >

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-30 Thread Joeri Sykora
On Thu, 29 Apr 2021 13:17:07 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on >> Windows, in order to match JDK 17 -- see >> [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). >> >> I ran a full build and test, including

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-04-30 Thread Kevin Rushforth
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 13:17:07 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on >> Windows, in order to match JDK 17 -- see >> [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). >> >> I ran a full build and test, including

Re: RFR: 8264998: Empty Jars shouldn't have Automatic-Module-Name

2021-04-30 Thread Kevin Rushforth
On Fri, 30 Apr 2021 08:42:14 GMT, Abhinay Agarwal wrote: > 8264998: Empty Jars shouldn't have Automatic-Module-Name Looks good. Pending review from either @johanvos or @tiainen - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/484

RFR: JDK-8264998: Remove Automatic-Module-Name from empty jars

2021-04-30 Thread Abhinay Agarwal
JDK-8264998: Remove Automatic-Module-Name from empty jars - Commit messages: - JDK-8264998: Remove Automatic-Module-Name from empty jars Changes: https://git.openjdk.java.net/jfx/pull/484/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=484=00 Issue: