Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v5]

2021-05-10 Thread Michael Strauß
On Tue, 11 May 2021 01:50:17 GMT, Michael Strauß wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >>

Re: RFR: JDK-8266396: Allow VSCMD_DEBUG to work as intended [v3]

2021-05-10 Thread John Neffenger
On Tue, 11 May 2021 01:17:32 GMT, John Neffenger wrote: >> The Windows build calls a series of batch files to get the Visual Studio >> paths and environment variables. The batch files are a black box: any >> messages they print are discarded. If anything goes wrong, the only signs >> are a

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v5]

2021-05-10 Thread Michael Strauß
> The documentation for `ObservableListBase.nextRemove` states that a single > change always refers to the current state of the list, which likely means > that multiple disjoint removed ranges need to be applied in order, otherwise > the next change's `getFrom` doesn't refer to the correct

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v4]

2021-05-10 Thread Michael Strauß
> The documentation for `ObservableListBase.nextRemove` states that a single > change always refers to the current state of the list, which likely means > that multiple disjoint removed ranges need to be applied in order, otherwise > the next change's `getFrom` doesn't refer to the correct

Re: RFR: JDK-8266396: Allow VSCMD_DEBUG to work as intended [v3]

2021-05-10 Thread John Neffenger
> The Windows build calls a series of batch files to get the Visual Studio > paths and environment variables. The batch files are a black box: any > messages they print are discarded. If anything goes wrong, the only signs are > a vague Gradle exception and a corrupted properties file. > >

Re: RFR: JDK-8266396: Allow VSCMD_DEBUG to work as intended [v2]

2021-05-10 Thread John Neffenger
On Mon, 10 May 2021 05:54:51 GMT, John Neffenger wrote: >> The Windows build calls a series of batch files to get the Visual Studio >> paths and environment variables. The batch files are a black box: any >> messages they print are discarded. If anything goes wrong, the only signs >> are a

[jfx11u] Integrated: 8264928: Update to Xcode 12.4

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:47:44 GMT, Kevin Rushforth wrote: > Almost clean backport to jfx11u (clean except for surrounding context in > `build.properties`). Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my >

[jfx11u] Integrated: 8262276: Debug build of WebKit fails

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:44:46 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my >

[jfx11u] Integrated: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:44:16 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my >

[jfx11u] Integrated: 8264990: WebEngine crashes with segfault when not loaded through system classloader

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:43:36 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my >

[jfx11u] Integrated: 8259356: MediaPlayer's seek freezes video

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:42:42 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my >

[jfx11u] Integrated: 8259555: Webkit crashes on Apple Silicon

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:42:09 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my >

[jfx11u] Integrated: 8211294: ScrollPane content is blurry with 125% scaling

2021-05-10 Thread Johan Vos
On Mon, 10 May 2021 16:36:53 GMT, Johan Vos wrote: > Clean backport for jfx11u . Builds and tests are green. This pull request has now been integrated. Changeset: 32fda115 Author:Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/32fda11550c1e2c7b19ef681082e03fb52552cfd

RFR: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem

2021-05-10 Thread Michael Strauß
This PR contains a fix that was de-scoped from #480 and solves an issue where an incorrect index is used in `MultipleSelectionModelBase.SelectedIndicesList.clear(int)`. - Commit messages: - Fixed incorrect index - Failing test Changes:

[jfx11u] RFR: 8211294: ScrollPane content is blurry with 125% scaling

2021-05-10 Thread Johan Vos
Clean backport for jfx11u . Builds and tests are green. - Commit messages: - 8211294: ScrollPane content is blurry with 125% scaling Changes: https://git.openjdk.java.net/jfx11u/pull/16/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=16=00 Issue:

[jfx11u] Integrated: 8258381: [macos] Exception when input emoji using Chinese input method

2021-05-10 Thread Johan Vos
On Mon, 10 May 2021 10:19:04 GMT, Johan Vos wrote: > Clean backport. > This only touches the macos platform, build and basic tests work fine. This pull request has now been integrated. Changeset: debddf79 Author:Johan Vos URL:

Integrated: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed

2021-05-10 Thread mstr2
On Sat, 24 Apr 2021 04:11:28 GMT, mstr2 wrote: > This PR fixes the implementation of `ControlUtils.reducingChange`, which > incorrectly computed adjacent removed indices, thus resulting in incorrect > removal notifications. > > Since there were no unit tests for this method, I also added a

[jfx11u] RFR: 8258381: [macos] Exception when input emoji using Chinese input method

2021-05-10 Thread Johan Vos
Clean backport. This only touches the macos platform, build and basic tests work fine. - Commit messages: - 8258381: [macos] Exception when input emoji using Chinese input method Changes: https://git.openjdk.java.net/jfx11u/pull/15/files Webrev:

RFR: 8264138: Replace uses of Class.newInstance

2021-05-10 Thread Ajit Ghaisas
This PR replaces Class.newInstance() deprecated method with Contructor.newinstance(). - Commit messages: - remove blankline - replace deprecated Class.newInstance Changes: https://git.openjdk.java.net/jfx/pull/491/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=491=00

[jfx11u] Integrated: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:41:06 GMT, Kevin Rushforth wrote: > This is a mostly-clean backport to jfx11u. The only merge conflicts I had to > fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the > static library support is not present in 11 (this is the exact same thing I >

Re: [jfx11u] RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-05-10 Thread Johan Vos
On Sat, 8 May 2021 15:41:06 GMT, Kevin Rushforth wrote: > This is a mostly-clean backport to jfx11u. The only merge conflicts I had to > fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the > static library support is not present in 11 (this is the exact same thing I >

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Jeanette Winzenburg
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Jeanette Winzenburg
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

[jfx11u] Integrated: 8240539: Upgrade gradle to version 6.3

2021-05-10 Thread Ambarish Rapte
On Fri, 7 May 2021 14:35:48 GMT, Ambarish Rapte wrote: > jfx11u uses gradle 5.3 for build, it needs to be upgraded to gradle 6.3 same > as jfx mainline. > This PR backports three fixes: > > 1. [JDK-8240539](https://bugs.openjdk.java.net/browse/JDK-8240539): Upgrade > gradle to version 6.3 >

[jfx11u] Integrated: 8204568: Relative CSS-Attributes don't work all time

2021-05-10 Thread Ambarish Rapte
On Fri, 7 May 2021 11:10:41 GMT, Ambarish Rapte wrote: > Backport had a minor merge conflict of copyright year in the file > `Labeled.java`. > Rest of the changes are clean backport This pull request has now been integrated. Changeset: fdd0fa09 Author:Ambarish Rapte URL:

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Ambarish Rapte
On Wed, 5 May 2021 09:32:30 GMT, Ambarish Rapte wrote: > We have couple more similar issues reported > > 1. [JDK-8255935](https://bugs.openjdk.java.net/browse/JDK-8255935) : > MultipleSelectionModel provides incorrect 'removed' sub-list in change events > 2.

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Ambarish Rapte
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-05-10 Thread Ambarish Rapte
On Sat, 3 Apr 2021 15:20:41 GMT, mstr2 wrote: > The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. > specializations of

Re: RFR: JDK-8266396: Add VSCMD_DEBUG for solving WINSDK_DIR build error [v2]

2021-05-10 Thread John Neffenger
On Mon, 10 May 2021 05:54:51 GMT, John Neffenger wrote: >> The Windows build calls a series of batch files to get the Visual Studio >> paths and environment variables. The batch files are a black box: any >> messages they print are discarded. If anything goes wrong, the only signs >> are a