> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS file
On Fri, 21 May 2021 11:48:21 GMT, Ajit Ghaisas wrote:
> The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors
> were deprecated for removal in openjfx16.
> This PR removes these constructors (targeted for openjfx17).
This pull request has now been integrated.
Changeset:
On Tue, 25 May 2021 10:40:50 GMT, Tom Schindl wrote:
>> Is there some reason you would prefer a Swing-style implementation over the
>> approach I submitted in this PR? The Swing code breaks down if an
>> accelerator calls for the Option modifier alone or in addition to Command.
>> I'm still in
$ grep -A2 'reg query' build/vcvarsall.log
C:\cygwin64\home\john\src\jfx>for /F "tokens=1,2*" %i in
('reg query "HKLM\SOFTWARE\Wow6432Node\Microsoft\Microsoft SDKs\Windows\v10.0"
I did it again -- started a line with a Windows command option inside a
Shell Session code block, resulting in a tru
On Thu, 13 May 2021 19:11:26 GMT, John Neffenger wrote:
>> John Neffenger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Skip sending telemetry to fix "file in use" error
>
> I wrote a Bash shell script, included below, that can help in
Maybe others will chime in regarding the thin vs. rich API discussion.
Regarding the extensibility of themes:
If Modena and Caspian were public API, you could extend those themes
simply by subclassing:
public class CustomTheme extends Modena {
private final ObservableList allStylesheets =
On Mon, 24 May 2021 05:02:45 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 55:
>>
>>> 53: * {@code falloff >= 0}; values outside either of these ranges can
>>> produce unexpected results.
>>> 54: *
>>> 55: *
>>
>> Should we have cone depi
On Mon, 24 May 2021 05:08:13 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
On Tue, 25 May 2021 09:04:07 GMT, Ambarish Rapte wrote:
> `StyleManager.calculateCheckSum()` uses a raw InputStream as the input to a
> `DigestInputStream` and reads one byte at a time. This is slower in
> performance and should be changed, either to use `BufferedInputStream` or
> read byte bu
On Thu, 13 May 2021 19:11:26 GMT, John Neffenger wrote:
>> John Neffenger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Skip sending telemetry to fix "file in use" error
>
> I wrote a Bash shell script, included below, that can help in
`StyleManager.calculateCheckSum()` uses a raw InputStream as the input to a
`DigestInputStream` and reads one byte at a time. This is slower in performance
and should be changed, either to use `BufferedInputStream` or read byte buffer
of 4096 from the stream or use both.
I have tried three appr
Again thanks for bringing this up into discussion and for taking the time
to file a PR, etc. I like the idea of having better support for themes.
Regarding your first point:
1 - To keep it simple we can discard the idea of having an API to be able
to check what are the OS settings for dark/light,
On Mon, 24 May 2021 15:25:22 GMT, Martin Fox
wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed whitespace error.
>
> Is there some reason you would prefer a Swing-style implementation over the
> approach I subm
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that `scenario.effect.light.Spo
GTK4 was just released not that long ago. I don't know how much(if any
at all) code is shared between versions, but having a tool like jextract
might be useful for adding support for that. Just a guess.
Also, the bindings are different in that, for everything not a primitive
in java(except bo
On Mon, 24 May 2021 05:08:13 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
I looked at jextract a while back. I got the impression that it's more
useful when you need to generate new bindings, at the very least because
there are fewer ways to make mistakes. Most of the work on JavaFX has
already been done in this area and the mistakes have been found and fixed
by now, so
Looks like the new features that we can use are:
- Switch expressions
- Records
- Text blocks
- Pattern matching for instanceof
None of them seem pressing. When we get the more complete set of pattern
matching (with switch, sealed classes, guards...) it will probably be
enough to merit an update.
18 matches
Mail list logo
