Integrated: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

2021-06-28 Thread Marius Hanl
On Mon, 28 Jun 2021 14:38:32 GMT, Marius Hanl wrote: > This PR fixes the issue identified and discussed in PR > https://github.com/openjdk/jfx/pull/506 which will make the gradle sync in > IntelliJ fail because of the failing dependency verification for source files. > > Gradle provides a way

Withdrawn: 8194924: Checking for selection size before update

2021-06-28 Thread Alexander Shaklein
On Thu, 24 Jun 2021 11:29:23 GMT, Alexander Shaklein wrote: > It is possible situation when `clearSelection()` is invoked during > `onChange()` notify. In such case `selectedCellsSeq` is clearing and possible > `IndexOutOfBoundsException` on `GenericAddRemoveChange` creation. > So we should

Re: RFR: 8269259: Remove obsolete apps, tests, and scripts

2021-06-28 Thread Nir Lisker
On Fri, 25 Jun 2021 14:59:00 GMT, Kevin Rushforth wrote: > This PR deletes the following applications, tests, and scripts that are > either obsolete > or unmaintained: > > apps/performance/* > > apps/tests/HelloTest > > apps/toys/FXSlideShow > apps/toys/Industrial > apps/toys/Shape3DToy >

RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-28 Thread Alexander Matveev
Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of cycle is reached regardless if it is repeating or not. - Commit messages: - 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc Changes:

Re: RFR: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

2021-06-28 Thread Nir Lisker
On Mon, 28 Jun 2021 14:38:32 GMT, Marius Hanl wrote: > This PR fixes the issue identified and discussed in PR > https://github.com/openjdk/jfx/pull/506 which will make the gradle sync in > IntelliJ fail because of the failing dependency verification for source files. > > Gradle provides a way

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v27]

2021-06-28 Thread Thiago Milczarek Sayao
> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > >

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v26]

2021-06-28 Thread Thiago Milczarek Sayao
> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > >

Re: RFR: 8194924: Checking for selection size before update

2021-06-28 Thread Kevin Rushforth
On Thu, 24 Jun 2021 11:29:23 GMT, Alexander Shaklein wrote: > It is possible situation when `clearSelection()` is invoked during > `onChange()` notify. In such case `selectedCellsSeq` is clearing and possible > `IndexOutOfBoundsException` on `GenericAddRemoveChange` creation. > So we should

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 04:08:30 GMT, Prasanta Sadhukhan wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > >

Re: RFR: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

2021-06-28 Thread Kevin Rushforth
On Mon, 28 Jun 2021 14:38:32 GMT, Marius Hanl wrote: > This PR fixes the issue identified and discussed in PR > https://github.com/openjdk/jfx/pull/506 which will make the gradle sync in > IntelliJ fail because of the failing dependency verification for source files. > > Gradle provides a way

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v2]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 21:10:16 GMT, Kevin Rushforth wrote: >> But the JobSettings class is final .. is it still necessary ? > > It's still a good idea to follow the pattern, so yes let's make the new > methods final. We can file a cleanup bug for the existing ones (and since the > class is

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 21:13:31 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > >

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v4]

2021-06-28 Thread Phil Race
On Thu, 24 Jun 2021 22:53:33 GMT, Phil Race wrote: >> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 490: >> >>> 488: * setting will be ignored. >>> 489: * If the URL specifies a non-existent path, or does not specify >>> 490: * a writable file it may be

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v4]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 21:08:31 GMT, Kevin Rushforth wrote: >> I agree with @kevinrushforth that if a String without protocol is passed, it >> should be treated as a file (absolute or relative to ?) >> I'm also not sure that the URL should be exposed here. I understand it's >> needed in the

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Phil Race
On Fri, 25 Jun 2021 21:20:53 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/j2d/print/J2DPrinterJob.java >> line 839: >> >>> 837: security.checkPrintJobAccess(); >>> 838: String file = settings.getOutputFile(); >>> 839: if

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v4]

2021-06-28 Thread Phil Race
> This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission to > write to, > then the printer output will be

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-28 Thread Philip Race
Yes .. we still need to deal with it until it is actually removed. Its going to be here for all the life of JDK 17 LTS which I expect FX will want to support for all that time. -phil. On 6/25/21 6:42 PM, Eric Bresie wrote: security manager That’s not the same security manager being discussed

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin

2021-06-28 Thread Jeanette Winzenburg
On Mon, 28 Jun 2021 13:18:38 GMT, Marius Hanl wrote: >> The issue is about memory leaks and side-effects (like NPEs) when switching >> skins. >> >> Details (copied from issue for convenience): >> >> memory leak in TextInputControlBehavior: >> - listener accidentally added twice (removed

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin

2021-06-28 Thread Jeanette Winzenburg
On Mon, 28 Jun 2021 12:55:47 GMT, Marius Hanl wrote: >> The issue is about memory leaks and side-effects (like NPEs) when switching >> skins. >> >> Details (copied from issue for convenience): >> >> memory leak in TextInputControlBehavior: >> - listener accidentally added twice (removed

RFR: 8269244: [IDE] Dependency verification of *-sources.jar fails when doing gradle sync

2021-06-28 Thread Marius Hanl
This PR fixes the issue identified and discussed in PR https://github.com/openjdk/jfx/pull/506 which will make the gradle sync in IntelliJ fail because of the failing dependency verification for source files. Gradle provides a way to skip the verification of source files, documented here:

Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]

2021-06-28 Thread Marius Hanl
On Thu, 24 Jun 2021 01:53:53 GMT, Michael Strauß wrote: >> * Expand the `Property.bind` and `Property.bindBidirectional` documentation >> * Change the name of the formal parameter of `Property.bind` to "source" >> (currently, it is inconsistently named "observable", "rawObservable" or >>

Re: RFR: 8240506: TextFieldSkin/Behavior: misbehavior on switching skin

2021-06-28 Thread Marius Hanl
On Thu, 17 Jun 2021 12:41:56 GMT, Jeanette Winzenburg wrote: > The issue is about memory leaks and side-effects (like NPEs) when switching > skins. > > Details (copied from issue for convenience): > > memory leak in TextInputControlBehavior: > - listener accidentally added twice (removed

RFR: 8234921: Add DirectionalLight to the selection of 3D light types

2021-06-28 Thread Nir Lisker
Adds a directional light as a subclass of `LightBase`. I think that this is the correct hierarchy for it. I tried to simulate a directional light by putting a point light far away, but I got artifacts when the distance was large. Instead, I added an on/off attenuation flag as the 4th component

Re: RFR: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later [v2]

2021-06-28 Thread Pankaj Bansal
On Mon, 28 Jun 2021 12:27:34 GMT, Kevin Rushforth wrote: >> This is a fix for the assertion error message that is printed to the console >> on macOS 10.15 or later when an application calls `Platform.exit` while a >> `Stage` is showing. >> >> The root cause is a latent bug in the JavaFX glass

Re: RFR: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later [v2]

2021-06-28 Thread Kevin Rushforth
On Sun, 27 Jun 2021 13:16:40 GMT, Pankaj Bansal wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix value of ERROR_TIMEOUT constant per code review > >

Re: RFR: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later [v2]

2021-06-28 Thread Kevin Rushforth
> This is a fix for the assertion error message that is printed to the console > on macOS 10.15 or later when an application calls `Platform.exit` while a > `Stage` is showing. > > The root cause is a latent bug in the JavaFX glass code that was revealed by > an apparent change of behavior in

Integrated: 8196065: ListChangeListener getRemoved() returns items that were not removed.

2021-06-28 Thread Michael Strauß
On Fri, 23 Apr 2021 03:19:03 GMT, Michael Strauß wrote: > The documentation for `ObservableListBase.nextRemove` states that a single > change always refers to the current state of the list, which likely means > that multiple disjoint removed ranges need to be applied in order, otherwise > the

Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]

2021-06-28 Thread Ambarish Rapte
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me