RFR: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached

2021-06-30 Thread Alexander Matveev
Not sure why, but our finish() handle was not implemented on OSXPlatform. This handle should pause media stream when called. Also, seek should restart playback when we finish playing video. With proposed fix OSXPlatform will behave same as GSTPlatform. Stop playback when stopTime is reached and

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v5]

2021-06-30 Thread Phil Race
On Wed, 30 Jun 2021 22:30:47 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - 8223717: javafx printing: Support Specifying Print to File in the API >> - 8223717: javafx printing: Support

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v5]

2021-06-30 Thread Kevin Rushforth
On Thu, 1 Jul 2021 00:15:13 GMT, Phil Race wrote: >> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 481: >> >>> 479: * such as Postscript or PDF, and the application intends to >>> distribute >>> 480: * the result instead of printing it, or for some other

Button label text garbled - OS/X Catalina

2021-06-30 Thread Michael Hall
I was looking at some JavaFX introductions. HelloWorld type things. In this case literally… https://docs.oracle.com/javafx/2/get_started/hello_world.htm The button labels show garbled text. Googling shows a number of similar examples. I found one issue indicating something very similar showing

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v6]

2021-06-30 Thread Phil Race
> This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission to > write to, > then the printer output will be

Integrated: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-30 Thread Alexander Matveev
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev wrote: > Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. This pull request has now been integrated. Changeset: cfa60ff7 Author:Alexander Matveev URL:

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v5]

2021-06-30 Thread Kevin Rushforth
On Wed, 30 Jun 2021 00:48:25 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Johan Vos
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Integrated: 8269147: Update GStreamer to version 1.18.4

2021-06-30 Thread Alexander Matveev
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.18.4. > - Tested on all platforms with all formats. This pull request has now been integrated. Changeset: 098c0f39 Author:Alexander Matveev URL:

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Marius Hanl
On Wed, 30 Jun 2021 16:16:16 GMT, Kevin Rushforth wrote: > Thanks for running the test. This is sufficient to show that the changed > layout will work with IntelliJ. > > What happens with the current layout, where src.zip is in the lib dir, if you > add the lib dir? Does IntelliJ fail in the

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Marius Hanl
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-06-30 Thread Marius Hanl
This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null. ChoiceBox: - Null check in **valueProperty()** listener ComboBox: - Null check in **valueProperty()** listener - Null check in **ComboBoxListViewSkin#updateValue()** The tests checks, that no NPE is printed to the

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Kevin Rushforth
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Marius Hanl
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-06-30 Thread Kevin Rushforth
The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. It provides a `src.zip` file for use by IDEs in that same `lib` directory. If a developer adds the `lib` directory to their application's module path in the IDE, it will try to load `src.zip` as if it were a jar file,

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-30 Thread Kevin Rushforth
On Wed, 30 Jun 2021 00:15:26 GMT, Alexander Matveev wrote: >> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of >> cycle is reached regardless if it is repeating or not. > > Alexander Matveev has updated the pull request incrementally with one > additional commit

Re: RFR: 8269147: Update GStreamer to version 1.18.4

2021-06-30 Thread Joeri Sykora
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.18.4. > - Tested on all platforms with all formats. We've also tested the changes on our build infrastructure and it all worked fine. - Marked as reviewed by sykora (Author). PR: