Not sure why, but our finish() handle was not implemented on OSXPlatform. This
handle should pause media stream when called. Also, seek should restart
playback when we finish playing video. With proposed fix OSXPlatform will
behave same as GSTPlatform. Stop playback when stopTime is reached and
On Wed, 30 Jun 2021 22:30:47 GMT, Kevin Rushforth wrote:
>> Phil Race has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - 8223717: javafx printing: Support Specifying Print to File in the API
>> - 8223717: javafx printing: Support
On Thu, 1 Jul 2021 00:15:13 GMT, Phil Race wrote:
>> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 481:
>>
>>> 479: * such as Postscript or PDF, and the application intends to
>>> distribute
>>> 480: * the result instead of printing it, or for some other
I was looking at some JavaFX introductions. HelloWorld type things. In this
case literally…
https://docs.oracle.com/javafx/2/get_started/hello_world.htm
The button labels show garbled text. Googling shows a number of similar
examples.
I found one issue indicating something very similar showing
> This enhancement adds the String property outputFileProperty() to the
> JobSettings class.
> The value should be a string that references a local file encoded as a URL.
> If this is non-null and set to a location that the user has permission to
> write to,
> then the printer output will be
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev
wrote:
> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of
> cycle is reached regardless if it is repeating or not.
This pull request has now been integrated.
Changeset: cfa60ff7
Author:Alexander Matveev
URL:
On Wed, 30 Jun 2021 00:48:25 GMT, Phil Race wrote:
>> This enhancement adds the String property outputFileProperty() to the
>> JobSettings class.
>> The value should be a string that references a local file encoded as a URL.
>> If this is non-null and set to a location that the user has
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote:
> The JavaFX SDK bundle provides a set of modular jars in the `lib` directory.
> It provides a `src.zip` file for use by IDEs in that same `lib` directory. If
> a developer adds the `lib` directory to their application's module path in
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev
wrote:
> - GStreamer updated to 1.18.4.
> - Tested on all platforms with all formats.
This pull request has now been integrated.
Changeset: 098c0f39
Author:Alexander Matveev
URL:
On Wed, 30 Jun 2021 16:16:16 GMT, Kevin Rushforth wrote:
> Thanks for running the test. This is sufficient to show that the changed
> layout will work with IntelliJ.
>
> What happens with the current layout, where src.zip is in the lib dir, if you
> add the lib dir? Does IntelliJ fail in the
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote:
> The JavaFX SDK bundle provides a set of modular jars in the `lib` directory.
> It provides a `src.zip` file for use by IDEs in that same `lib` directory. If
> a developer adds the `lib` directory to their application's module path in
This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null.
ChoiceBox:
- Null check in **valueProperty()** listener
ComboBox:
- Null check in **valueProperty()** listener
- Null check in **ComboBoxListViewSkin#updateValue()**
The tests checks, that no NPE is printed to the
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote:
> The JavaFX SDK bundle provides a set of modular jars in the `lib` directory.
> It provides a `src.zip` file for use by IDEs in that same `lib` directory. If
> a developer adds the `lib` directory to their application's module path in
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote:
> The JavaFX SDK bundle provides a set of modular jars in the `lib` directory.
> It provides a `src.zip` file for use by IDEs in that same `lib` directory. If
> a developer adds the `lib` directory to their application's module path in
The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. It
provides a `src.zip` file for use by IDEs in that same `lib` directory. If a
developer adds the `lib` directory to their application's module path in the
IDE, it will try to load `src.zip` as if it were a jar file,
On Wed, 30 Jun 2021 00:15:26 GMT, Alexander Matveev
wrote:
>> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of
>> cycle is reached regardless if it is repeating or not.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev
wrote:
> - GStreamer updated to 1.18.4.
> - Tested on all platforms with all formats.
We've also tested the changes on our build infrastructure and it all worked
fine.
-
Marked as reviewed by sykora (Author).
PR:
17 matches
Mail list logo