Re: RFR: 8269131: Update libxml2 to version 2.9.12

2021-07-01 Thread Kevin Rushforth
On Thu, 1 Jul 2021 15:46:53 GMT, Ambarish Rapte wrote: > We currently use libxml2 version 2.9.10. It should be updated to latest > stable release, which is version 2.9.12. > The steps to update libxml are documented in UPDATING.txt. The changes look good except for the expansion of tags in

Re: RFR: 8269593: Different fontname on macos [v2]

2021-07-01 Thread Phil Race
On Tue, 29 Jun 2021 14:20:30 GMT, Johan Vos wrote: >> Make sure the returned fullName of a created font matches the requested >> name. Since the name is used as a key/identifier in some cases, some >> internal code relies on this. >> Added a test to check the case of "System Font Regular" on

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-01 Thread Phil Race
On Thu, 1 Jul 2021 20:53:36 GMT, Phil Race wrote: >> [Mac only] register system fonts. >> Fix for JDK-8246104 >> >> The list of available fonts returned by >> CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at >> least not by default, although this is not

Re: RFR: 8268849: Update to 612.1 version of WebKit

2021-07-01 Thread Kevin Rushforth
On Thu, 1 Jul 2021 08:32:31 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.32 (612.1). > There are two separate commits: > 1. > [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) > : includes only native changes > 2. >

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-01 Thread Phil Race
On Sat, 26 Jun 2021 15:40:47 GMT, Johan Vos wrote: > [Mac only] register system fonts. > Fix for JDK-8246104 > > The list of available fonts returned by > CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at > least not by default, although this is not documented). By

Re: Button label text garbled - OS/X Catalina

2021-07-01 Thread Michael Hall
> On Jun 30, 2021, at 6:44 PM, Michael Hall wrote: > > I was looking at some JavaFX introductions. HelloWorld type things. In this > case literally… > https://docs.oracle.com/javafx/2/get_started/hello_world.htm > > The button labels show garbled text. Googling shows a number of similar >

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-07-01 Thread Jeanette Winzenburg
On Wed, 30 Jun 2021 15:03:50 GMT, Marius Hanl wrote: > This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **valueProperty()** listener > - Null check in

RFR: 8269131: Update libxml2 to version 2.9.12

2021-07-01 Thread Ambarish Rapte
We currently use libxml2 version 2.9.10. It should be updated to latest stable release, which is version 2.9.12. The steps to update libxml are documented in UPDATING.txt. - Commit messages: - libxml update Changes: https://git.openjdk.java.net/jfx/pull/562/files Webrev:

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-07-01 Thread Marius Hanl
On Thu, 1 Jul 2021 15:29:01 GMT, Marius Hanl wrote: > I don't see any benefit with a noop selection model, but we need/should > cleanup some null checks and somehow still silently set a selection model > while we as a developer set it to null (so I guess we expected null to be > returned when

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-07-01 Thread Marius Hanl
On Wed, 30 Jun 2021 15:03:50 GMT, Marius Hanl wrote: > This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **valueProperty()** listener > - Null check in

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-07-01 Thread Marius Hanl
On Thu, 1 Jul 2021 14:52:28 GMT, Jeanette Winzenburg wrote: >> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is >> null. >> >> ChoiceBox: >> - Null check in **valueProperty()** listener >> >> ComboBox: >> - Null check in **valueProperty()** listener >> - Null check

Re: RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-07-01 Thread Jeanette Winzenburg
On Wed, 30 Jun 2021 15:03:50 GMT, Marius Hanl wrote: > This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **valueProperty()** listener > - Null check in

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v6]

2021-07-01 Thread Kevin Rushforth
On Thu, 1 Jul 2021 00:38:25 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has

RFR: 8268849: Update to 612.1 version of WebKit

2021-07-01 Thread Ambarish Rapte
Update JavaFX WebKit to GTK WebKit 2.32 (612.1). There are two separate commits: 1. [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) : includes only native changes 2. [commit](https://github.com/openjdk/jfx/commit/b024c16551be7d929fa1d927d3be8f0fc75a64c3)

RFR: 8187229: Tree/TableCell: cancel event must return correct editing location

2021-07-01 Thread Jeanette Winzenburg
the bug is an incorrect edit location (for Tree/Table: Tree/TablePosition) in edit cancel events - expected is the location at the time the cell edit was started, actual was the location of at the time the edit was cancelled. See the report for details. The fix is analogue to those for

Re: Integrated: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later

2021-07-01 Thread Kevin Rushforth
Unrelated, since this fix is in macOS-specific platform code. -- Kevin On 7/1/2021 4:33 AM, Ty Young wrote: Does this also fix the free(): invalid pointer issue when closing a JavaFX application on Linux or is that unrelated? On 7/1/21 6:17 AM, Kevin Rushforth wrote: On Tue, 22 Jun 2021

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-07-01 Thread Eric Bresie
Was reading https://stackoverflow.com/questions/29258944/where-is-the-src-zip-for-jdk8u40 on location on sec.zip and they had in similar layout for JDK and Java-Jax locations. Assume as long as jfx isn’t loaded at the same location as JDK (which since it’s a separate project now) this

Re: Integrated: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later

2021-07-01 Thread Ty Young
Does this also fix the free(): invalid pointer issue when closing a JavaFX application on Linux or is that unrelated? On 7/1/21 6:17 AM, Kevin Rushforth wrote: On Tue, 22 Jun 2021 20:42:48 GMT, Kevin Rushforth wrote: This is a fix for the assertion error message that is printed to the

Integrated: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later

2021-07-01 Thread Kevin Rushforth
On Tue, 22 Jun 2021 20:42:48 GMT, Kevin Rushforth wrote: > This is a fix for the assertion error message that is printed to the console > on macOS 10.15 or later when an application calls `Platform.exit` while a > `Stage` is showing. > > The root cause is a latent bug in the JavaFX glass code

Integrated: 8258499: JavaFX: Move src.zip out of the lib directory

2021-07-01 Thread Kevin Rushforth
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in

Re: RFR: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later [v2]

2021-07-01 Thread Ajit Ghaisas
On Mon, 28 Jun 2021 12:27:34 GMT, Kevin Rushforth wrote: >> This is a fix for the assertion error message that is printed to the console >> on macOS 10.15 or later when an application calls `Platform.exit` while a >> `Stage` is showing. >> >> The root cause is a latent bug in the JavaFX glass

Re: RFR: 8258499: JavaFX: Move src.zip out of the lib directory

2021-07-01 Thread Ajit Ghaisas
On Wed, 30 Jun 2021 15:06:50 GMT, Kevin Rushforth wrote: > The JavaFX SDK bundle provides a set of modular jars in the `lib` directory. > It provides a `src.zip` file for use by IDEs in that same `lib` directory. If > a developer adds the `lib` directory to their application's module path in