On Thu, 1 Jul 2021 01:38:14 GMT, Alexander Matveev wrote:
> Not sure why, but our finish() handle was not implemented on OSXPlatform.
> This handle should pause media stream when called. Also, seek should restart
> playback when we finish playing video. With proposed fix OSXPlatform will
>
On Thu, 8 Jul 2021 11:59:05 GMT, Jeanette Winzenburg
wrote:
>>> Hmm ... wondering whether we really want to widen the scope of this issue
>>>
>>> * it started with being focused on NPE on the change of property value,
>>> for both Choice/ComboBox
>>>
>>> * turned out combo's skin
On Thu, 8 Jul 2021 21:24:28 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableCellSkin.java
>> line 107:
>>
>>> 105:
>>> 106: @Override
>>> 107: protected void layoutChildren(double x, double y, double w, double
>>> h) {
>>
>> This
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
> This will prevent a NPE while also being cleaner (no more double checks)
> The
On Thu, 24 Jun 2021 01:53:53 GMT, Michael Strauß wrote:
>> * Expand the `Property.bind` and `Property.bindBidirectional` documentation
>> * Change the name of the formal parameter of `Property.bind` to "source"
>> (currently, it is inconsistently named "observable", "rawObservable" or
>>
> This PR fixes a long standing issue with the TreeTableView indentation.
>
> 
>
> In short:
> **TreeTableCellSkin** overrides **leftLabelPadding()** to calculate the
> indentation
This PR implements a version check in the JavaFX runtime initialization code on
macOS to ensure that the platform is running a version of macOS that is at or
above the minimum version. If the platform is below the specified minimum, the
JavaFX initialization code throws an exception.
The
On Wed, 7 Jul 2021 23:57:31 GMT, Kevin Rushforth wrote:
>> This PR fixes a long standing issue with the TreeTableView indentation.
>>
>> 
>>
>> In short:
>> **TreeTableCellSkin**
On Thu, 8 Jul 2021 10:52:06 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fixed NPE for setEditable() and layoutChildren()
>> - removed unneeded button cell in test
>
>
On Wed, 7 Jul 2021 22:33:07 GMT, Marius Hanl wrote:
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
> This will prevent a NPE while
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
> This will prevent a NPE while also being cleaner (no more double checks)
> The
On Thu, 1 Jul 2021 01:38:14 GMT, Alexander Matveev wrote:
> Not sure why, but our finish() handle was not implemented on OSXPlatform.
> This handle should pause media stream when called. Also, seek should restart
> playback when we finish playing video. With proposed fix OSXPlatform will
>
On Wed, 7 Jul 2021 09:48:20 GMT, Jeanette Winzenburg
wrote:
>> The issue is about memory leaks and side-effects (like NPEs) when switching
>> skins.
>>
>> Details (copied from issue for convenience):
>>
>> memory leak in TextInputControlBehavior:
>> - listener accidentally added twice
On Wed, 7 Jul 2021 10:02:52 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/behavior/BehaviorCleanupTest.java
>> line 404:
>>
>>> 402: }
>>> 403: if (!root.getChildren().contains(control)) {
>>> 404:
JavaFX 17 is now in Rampdown Phase One (RDP1) [1]. We have forked a new
jfx17 branch [2] for stabilizing the JavaFX 17 release.
Here is the short summary of what this means:
- The master branch of the jfx repo is available for integrating bug
fixes or enhancements for openjfx18. Most fixes
On Tue, 29 Jun 2021 14:21:27 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 18. I will integrate this immediately
> after forking the `jfx17` stabilization branch, which is scheduled for
> Thursday, July 8, 2021 at 16:00 UTC.
>
> ~~Leaving it as `Draft` for now. I'll make
On Thu, 8 Jul 2021 11:19:57 GMT, Ajit Ghaisas wrote:
> > the first two are naturally within the original scope, the third is near
> > enough (a property on one of the covered controls) to be included .. the
> > last is arguable, IMO - would tend to not include it here but open a
> > follow-up
On Wed, 7 Jul 2021 22:33:07 GMT, Marius Hanl wrote:
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
> This will prevent a NPE while
On Thu, 8 Jul 2021 10:28:22 GMT, Jeanette Winzenburg
wrote:
>> hmm ... can't unresolve this (probably because I wasn't involved?) - how to
>> make it part of the review?
>
> hmm .. looks like I can only add comments to a review when being on the
> "files changed" tab, but not on the
On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()* listener*
>> - Null check
On Thu, 8 Jul 2021 10:19:54 GMT, Jeanette Winzenburg
wrote:
>> Hmm ... wondering whether we really want to widen the scope of this issue
>>
>> - it started with being focused on NPE on the change of property value, for
>> both Choice/ComboBox
>> - turned out combo's skin also has a throwing
On Wed, 7 Jul 2021 19:29:53 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java
>> line 401:
>>
>>> 399: private void updateValue() {
>>> 400: SingleSelectionModel comboBoxSM =
>>> comboBox.getSelectionModel();
>>>
On Thu, 8 Jul 2021 10:18:13 GMT, Jeanette Winzenburg
wrote:
>> added.
>
> Hmm ... wondering whether we really want to widen the scope of this issue
>
> - it started with being focused on NPE on the change of property value, for
> both Choice/ComboBox
> - turned out combo's skin also has a
On Wed, 7 Jul 2021 19:37:23 GMT, Marius Hanl wrote:
>> This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model
>> is null.
>>
>> ChoiceBox:
>> - Null check in **valueProperty()** listener
>>
>> ComboBox:
>> - Null check in **editableProperty()* listener*
>> - Null check
24 matches
Mail list logo
