Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-09 Thread Nir Lisker
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote: >> Added convenience factory factory methods for Background and Border. > > Nir Lisker has updated the pull request incrementally with two additional > commits since the last revision: > > - Removed whitespaces > - Added tests and doc

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-09 Thread Nir Lisker
> Added convenience factory factory methods for Background and Border. Nir Lisker has updated the pull request incrementally with two additional commits since the last revision: - Removed whitespaces - Added tests and doc updates - Changes: - all:

Re: RFR: 8272870: Add convenience factory methods for border and background [v2]

2021-09-09 Thread Nir Lisker
On Tue, 7 Sep 2021 06:31:18 GMT, Ambarish Rapte wrote: >> Since the `Background` constructors take a list of `Paint` objects, I think >> saying a "single" `{@code Paint}` is helpful. I can see how adding "for >> `BackgroundFill`" (or maybe "as a `BackgroundFill`"?) might make it clearer. > >

Re: RFR: 8272870: Add convenience factory methods for border and background [v2]

2021-09-09 Thread Nir Lisker
On Fri, 3 Sep 2021 21:08:27 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java >> line 366: >> >>> 364: */ >>> 365: public static Background fill(Paint fill) { >>> 366: return new Background(new BackgroundFill(fill, null,

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v8]

2021-09-09 Thread Jose Pereda
On Thu, 9 Sep 2021 08:52:31 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: [External] : Re: apps compilation fails on ubuntu 20.04

2021-09-09 Thread Dean Wookey
I'm having the same issue on Windows. I'm not really sure what's different about my setup. Originally I thought it was failing every time, but every now and then it gets past that and successfully builds for me. After changing from JDK 15.0.2 to 16.0.2 it worked, but that's when I realised it was

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v8]

2021-09-09 Thread Kevin Rushforth
On Thu, 9 Sep 2021 08:52:31 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: [External] : Re: Pivot properties [was: Enhancements for JavaFX 18]

2021-09-09 Thread Nir Lisker
I have updated the PR to use DoubleProperties for the pivots and added 2 BooleanProperties for the normalized coordinates toggle on Node. To the Rotate/ScaleTransitions I added only the pivot properties that update those of the node. It's a prototype, so ignore docs and other miscellania. I also

Re: RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v7]

2021-09-09 Thread Jeanette Winzenburg
On Thu, 9 Sep 2021 09:47:56 GMT, Michael Strauß wrote: > > > > Just curious: with this in place, would it be possible to use for > > supporting [JDK-8087926](https://bugs.openjdk.java.net/browse/JDK-8087926) > > (it's a bit vague, though, at least for me)? > > Yes, `:focus-within` can be

Re: RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v7]

2021-09-09 Thread Michael Strauß
On Thu, 9 Sep 2021 09:15:06 GMT, Jeanette Winzenburg wrote: > Just curious: with this in place, would it be possible to use for supporting > [JDK-8087926](https://bugs.openjdk.java.net/browse/JDK-8087926) (it's a bit > vague, though, at least for me)? Yes, `:focus-within` can be used to

Re: RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v7]

2021-09-09 Thread Jeanette Winzenburg
On Fri, 20 Aug 2021 05:15:49 GMT, Michael Strauß wrote: >> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as >> well as the corresponding `:focus-visible` and `:focus-within` CSS >> pseudo-classes. > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v8]

2021-09-09 Thread Jose Pereda
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but > the class is not public. Therefore, public API is needed in `WebView` to > allow developers access to it. > > In line with the `fontSmoothingType` property, this PR provides public > support for setting the

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v7]

2021-09-09 Thread Jose Pereda
On Wed, 8 Sep 2021 21:08:40 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback from reviewers > > modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 2589: > >>

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v7]

2021-09-09 Thread Jose Pereda
On Wed, 8 Sep 2021 22:37:18 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 707: >> >>> 705: * level of transparency. >>> 706: * >>> 707: * However, if the HTML content being loaded sets its own >> >> I looked at the generated

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v7]

2021-09-09 Thread Jose Pereda
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Integrated: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

2021-09-09 Thread Marius Hanl
On Wed, 30 Jun 2021 15:03:50 GMT, Marius Hanl wrote: > This PR fixes multiple NPEs in Choice-and ComboBox, when the selection model > is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **editableProperty()** listener > - Null check in

Re: RFR: 8172095: Let Node.managed become CSS-styleable [v2]

2021-09-09 Thread Ambarish Rapte
On Sat, 4 Sep 2021 15:44:17 GMT, Abhinay Agarwal wrote: >> 8172095: Let Node.managed become CSS-styleable > > Abhinay Agarwal has updated the pull request incrementally with two > additional commits since the last revision: > > - Add default value tests for setting / getting the managed

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac

2021-09-09 Thread Florian Kirmaier
On Wed, 8 Sep 2021 10:37:40 GMT, Florian Kirmaier wrote: > When using Swing it's possible to generate a Deadlock. > It's related to the nested eventloop started in enterFullScreenExitingLoop - > and the RenderLock aquired when using setView in Scene. > Sample Programm and Threaddump are added