Re: [jfx17u] RFR: 8273732: Clarify review policies for clean backports in JavaFX update releases [v2]

2021-09-15 Thread Pankaj Bansal
On Wed, 15 Sep 2021 23:06:39 GMT, Kevin Rushforth wrote: >> Added a paragraph indicating that a review of a clean backport to an update >> release is optional, if the bug in question has been approved for inclusion >> into the release. > > Kevin Rushforth has updated the pull request

Re: [jfx17u] RFR: 8273732: Clarify review policies for clean backports in JavaFX update releases [v2]

2021-09-15 Thread Phil Race
On Wed, 15 Sep 2021 23:06:39 GMT, Kevin Rushforth wrote: >> Added a paragraph indicating that a review of a clean backport to an update >> release is optional, if the bug in question has been approved for inclusion >> into the release. > > Kevin Rushforth has updated the pull request

Re: [jfx17u] RFR: 8273732: Clarify review policies for clean backports in JavaFX update releases [v2]

2021-09-15 Thread Kevin Rushforth
> Added a paragraph indicating that a review of a clean backport to an update > release is optional, if the bug in question has been approved for inclusion > into the release. Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:

[jfx17u] Integrated: 8272329: Cherry pick GTK WebKit 2.32.3 changes

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 21:23:17 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. This pull request has now been integrated. Changeset: 2947986a Author:Kevin Rushforth URL:

[jfx17u] RFR: 8273732: Clarify review policies for clean backports in JavaFX update releases

2021-09-15 Thread Kevin Rushforth
Added a paragraph indicating that a review of a clean backport to an update release is optional, if the bug in question has been approved for inclusion into the release. - Commit messages: - 8273732: Clarify review policies for clean backports in JavaFX update releases Changes:

[jfx17u] Integrated: 8270479: WebKit 612.1 build fails with Visual Studio 2017

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 21:22:49 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. This pull request has now been integrated. Changeset: 5397290f Author:Kevin Rushforth URL:

[jfx17u] RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes

2021-09-15 Thread Kevin Rushforth
Clean backport to `jfx17u`. This has been tested on all platforms along with other pending fixes in the `test-kcr-17.0.1` branch. - Commit messages: - 8272329: Cherry pick GTK WebKit 2.32.3 changes Changes: https://git.openjdk.java.net/jfx17u/pull/8/files Webrev:

Re: [jfx17u] RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 21:23:17 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. NOTE: I verified that after this PR and PR #7 are applied, `modules/javafx.web/src/main/native` is

Re: [jfx17u] RFR: 8270479: WebKit 612.1 build fails with Visual Studio 2017

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 21:22:49 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. NOTE: I verified that after this PR and PR #8 are applied, `modules/javafx.web/src/main/native` is

[jfx17u] RFR: 8270479: WebKit 612.1 build fails with Visual Studio 2017

2021-09-15 Thread Kevin Rushforth
Clean backport to `jfx17u`. This has been tested on all platforms along with other pending fixes in the `test-kcr-17.0.1` branch. - Commit messages: - 8270479: WebKit 612.1 build fails with Visual Studio 2017 Changes: https://git.openjdk.java.net/jfx17u/pull/7/files Webrev:

Re: [jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Kevin Rushforth
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. Thanks for the review and the sanity check. > There are only differences of copyright year. jfx17

[jfx17u] Integrated: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Kevin Rushforth
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. This pull request has now been integrated. Changeset: 092c20b0 Author:Kevin Rushforth URL:

Re: [jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Ambarish Rapte
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. Marked as reviewed by arapte (Reviewer). If we compare modules/javafx.web/src/main/native/Source of

[jfx17u] Integrated: 8273324: IllegalArgumentException: fromIndex(0) > toIndex(-1) after clear and select TableCell

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 18:56:37 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested along with other pending > fixes in the `test-kcr-17.0.1` branch. This pull request has now been integrated. Changeset: 62355c90 Author:Kevin Rushforth URL:

[jfx17u] Integrated: 8273138: BidirectionalBinding fails to observe changes of invalid properties

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 18:56:07 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested along with other pending > fixes in the `test-kcr-17.0.1` branch. This pull request has now been integrated. Changeset: ff4a6259 Author:Kevin Rushforth URL:

[jfx17u] Integrated: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 18:55:23 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested along with other pending > fixes in the `test-kcr-17.0.1` branch. This pull request has now been integrated. Changeset: 3c6596b3 Author:Kevin Rushforth URL:

[jfx17u] RFR: 8273324: IllegalArgumentException: fromIndex(0) > toIndex(-1) after clear and select TableCell

2021-09-15 Thread Kevin Rushforth
Clean backport to `jfx17u`. This has been tested along with other pending fixes in the `test-kcr-17.0.1` branch. - Commit messages: - 8273324: IllegalArgumentException: fromIndex(0) > toIndex(-1) after clear and select TableCell Changes:

[jfx17u] RFR: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached

2021-09-15 Thread Kevin Rushforth
Clean backport to `jfx17u`. This has been tested along with other pending fixes in the `test-kcr-17.0.1` branch. - Commit messages: - 8268718: [macos] Video stops, but audio continues to play when stopTime is reached Changes: https://git.openjdk.java.net/jfx17u/pull/4/files

[jfx17u] RFR: 8273138: BidirectionalBinding fails to observe changes of invalid properties

2021-09-15 Thread Kevin Rushforth
Clean backport to `jfx17u`. This has been tested along with other pending fixes in the `test-kcr-17.0.1` branch. - Commit messages: - 8273138: BidirectionalBinding fails to observe changes of invalid properties Changes: https://git.openjdk.java.net/jfx17u/pull/5/files Webrev:

Re: [jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Kevin Rushforth
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. For some reason, Skara didn't mark this as clean, so it needs a (sanity) review. @arapte Can you

[jfx17] Integrated: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-15 Thread Johan Vos
On Wed, 15 Sep 2021 15:57:24 GMT, Johan Vos wrote: > Reviewed-by: kcr, jvos This pull request has now been integrated. Changeset: 3a677c41 Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/3a677c418b517a4868ae44bd66209aab83c29588 Stats: 5 lines in 1 file changed: 5

[jfx17] RFR: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-15 Thread Johan Vos
Reviewed-by: kcr, jvos - Commit messages: - 8273754: Re-introduce Automatic-Module-Name in empty jars Changes: https://git.openjdk.java.net/jfx/pull/625/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=625=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273754

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-15 Thread Ambarish Rapte
On Wed, 15 Sep 2021 13:04:52 GMT, Kevin Rushforth wrote: > another possibility is to just capitalize the first occurrence and leave the > others as lower-case? That sounds good too, so only the first occurrence would be changed. - PR: https://git.openjdk.java.net/jfx/pull/610

[jfx17] Integrated: 8273824: Update JavaFX release version to 17.0.0.1 in jfx/jfx17 branch

2021-09-15 Thread Johan Vos
On Wed, 15 Sep 2021 14:50:03 GMT, Johan Vos wrote: > This release is needed with a backport of JDK-8273754 This pull request has now been integrated. Changeset: bd872404 Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/bd87240425f5eb89b14c01dc71bc0342233c1140 Stats:

JavaFX metal rendering pipeline for macOS

2021-09-15 Thread Kevin Rushforth
We just pushed an early prototype of a new JavaFX Metal rendering pipeline for macOS to a new "metal" branch of jfx-sandbox. We called it "metal" with no bug ID or username prefix, to highlight that it is more than an experiment: It is intended to be the branch where we will develop the metal

Re: [jfx17] RFR: 8273824: Update JavaFX release version to 17.0.0.1 in jfx/jfx17 branch

2021-09-15 Thread Kevin Rushforth
On Wed, 15 Sep 2021 14:50:03 GMT, Johan Vos wrote: > This release is needed with a backport of JDK-8273754 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/624

[jfx17] RFR: 8273824: Update JavaFX release version to 17.0.0.1 in jfx/jfx17 branch

2021-09-15 Thread Johan Vos
This release is needed with a backport of JDK-8273754 - Commit messages: - Increase patch version to build 17.0.0.1 Changes: https://git.openjdk.java.net/jfx/pull/624/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=624=00 Issue:

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-15 Thread Nir Lisker
On Wed, 15 Sep 2021 11:08:04 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Removed whitespaces >> - Added tests and doc updates > >

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-15 Thread Kevin Rushforth
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote: >> Added convenience factory factory methods for Background and Border. > > Nir Lisker has updated the pull request incrementally with two additional > commits since the last revision: > > - Removed whitespaces > - Added tests and doc

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-15 Thread Ambarish Rapte
On Wed, 15 Sep 2021 11:03:20 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Removed whitespaces >> - Added tests and doc updates > >

Re: RFR: 8272870: Add convenience factory methods for border and background [v3]

2021-09-15 Thread Ambarish Rapte
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote: >> Added convenience factory factory methods for Background and Border. > > Nir Lisker has updated the pull request incrementally with two additional > commits since the last revision: > > - Removed whitespaces > - Added tests and doc

Re: Proof of concept for fluent bindings for ObservableValue

2021-09-15 Thread John Hendrikx
On 15/09/2021 02:28, Nir Lisker wrote: Sorry, I'm not quite sure what you mean by this. Could you elaborate? The methods orElse and orElseGet are present in the PoC, and I think they're highly useful to have to deal with nulls. The methods that you call orElse and orElseGet

Integrated: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-15 Thread Abhinay Agarwal
On Tue, 14 Sep 2021 20:59:47 GMT, Abhinay Agarwal wrote: > Re-introduce `Automatic-Module-Name` for empty jars until a better > alternative to empty jars has been finalized. This pull request has now been integrated. Changeset: 7329279e Author:Abhinay Agarwal Committer: Johan Vos URL:

Re: RFR: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-15 Thread Johan Vos
On Tue, 14 Sep 2021 20:59:47 GMT, Abhinay Agarwal wrote: > Re-introduce `Automatic-Module-Name` for empty jars until a better > alternative to empty jars has been finalized. This is ok. For the long-term solution, we need a clear and consistent view on what the best approach is to deal with