Probably my most boring PR. ;)
Setting the lambda to null, after it has been used, fixes the leak.
-
Commit messages:
- JDK-8273969
Changes: https://git.openjdk.java.net/jfx/pull/626/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=626=00
Issue:
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier
wrote:
> Probably my most boring PR. ;)
> Setting the lambda to null, after it has been used, fixes the leak.
For the strange reason, why i haven't used a lambda for the test, I've created
another ticket:
I need to get you the tests I wrote, unfortunately, they're JUnit 5,
please see the tests here:
https://github.com/hjohn/MediaSystem-v2/tree/master/mediasystem-jfx/src/test/java/javafx/beans/value
The OrElseBinding is incorrect, the compute value should read:
protected T computeValue() {
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
> This will prevent a NPE while also being cleaner (no more double checks)
> The
On Thu, 19 Aug 2021 12:25:16 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Separated test and made the cell a supplier instead
>
>
On Thu, 19 Aug 2021 12:16:28 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Separated test and made the cell a supplier instead
>
>
On Thu, 16 Sep 2021 21:15:20 GMT, Kevin Rushforth wrote:
> > > ```
> > > public static Border stroke(Paint stroke, double width) {
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > ...
> > > But I really want to hear other
