Re: RFR: 8274137: TableView scrollbar/header misaligned when reloading data [v3]

2021-09-26 Thread Robert Lichtenberger
> This PR fixes JDK-8274137 by removing the optimization from updateHbar() that > will no-op the method in case the VirtualFlow is invisible or currently has > no scene. > Since changes to the hBar's value can happen even if the VirtualFlow is not > currently visible, the synchronisation between

Re: RFR: 8274137: TableView scrollbar/header misaligned when reloading data [v2]

2021-09-26 Thread Robert Lichtenberger
On Fri, 24 Sep 2021 11:22:22 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274137: TableView scrollbar/header misaligned when reloading data >> >> Alternative fix using addition

Re: CFV: New OpenJFX Committer: Thiago Sayao

2021-09-26 Thread John Neffenger
Vote: YES Just in time, John On 9/13/21 7:37 AM, Kevin Rushforth wrote: I hereby nominate Thiago Sayao [1] to OpenJFX Committer. Thiago is an OpenJFX community member, who has contributed 15 commits [2] to OpenJFX. Votes are due by September 27, 2021 at 15:00 UTC. Only current OpenJFX Comm

Re: Re: Proof of concept for fluent bindings for ObservableValue

2021-09-26 Thread Eric Bresie
I’m no expert here so take it with a grain of salt but… I was proposing moving this sorts of ObservableValue type interfaces and implementations out of jfx (and React) context and into JDK context. Then these sorts of observable type properties/ bindings can be used outside of just UI contexts.

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v4]

2021-09-26 Thread Jeanette Winzenburg
On Sun, 19 Sep 2021 11:24:43 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/cell/ChoiceBoxTreeCell.java >> line 301: >> >>> 299: return; >>> 300: } >>> 301: >> >> (darn, can't add the important lines - which is backing out if treeItem

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v5]

2021-09-26 Thread Jeanette Winzenburg
On Sun, 19 Sep 2021 11:52:55 GMT, Marius Hanl wrote: >> This PR sets an unified logic to every **startEdit()** method of all Cell >> implementations. >> So startEdit() is always doing the same now: >> >> `super.startEdit();` >> `if (!isEditing()) { >> return; >> }` >> >> This will prevent a N