Re: Mac drag-and-drop questions

2021-09-30 Thread Martin Fox
Kevin, As a heads up there are actually two behavior changes to be reviewed. JavaFX is picking up some archaic behavior from the OS which thinks that the modifier key for LINK is Control. The Finder switched over to Option+Command a long time ago and I think JavaFX should follow suit. As for

Re: Mac drag-and-drop questions

2021-09-30 Thread Kevin Rushforth
If changing the default behavior makes it consistent with native apps on macOS and with JavaFX apps on other platforms, then it seems like the right thing to do. We would want a CSR for the behavior change As for your question about finding the bug using the old "RT-" bug ID, you can just

Mac drag-and-drop questions

2021-09-30 Thread Martin Fox
I was just looking at JDK-8237329 which is a drag-and-drop bug on the Mac; holding down the Command key alone is guaranteed to disable an internal dnd operation. I’m putting together a PR to fix this. While going through the bug database looking for related bugs I ran across JDK-8153032 which

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-09-30 Thread Kevin Rushforth
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus wrote: >> Fixes the issue by using the "open" command as discussed before. >> See: https://bugs.openjdk.java.net/browse/JDK-8214158 > > Michael Paus has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-09-30 Thread Michael Paus
> Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Fixed two minor formatting issues - Changes: -

RFR: 8274433: All Cells: misbehavior of startEdit

2021-09-30 Thread Jeanette Winzenburg
The misbehavior happens if (super) startEdit didn't succeed (== !cell.isEditing): - must not fire editStart event - must not update control's editing location fix is to back out of startEdit if super.startEdit doesn't switch the cell into editing mode Added tests that failed/passed

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-09-30 Thread Thiago Milczarek Sayao
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window =

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v4]

2021-09-30 Thread Kevin Rushforth
On Wed, 29 Sep 2021 13:20:08 GMT, Michael Paus wrote: >> Fixes the issue by using the "open" command as discussed before. >> See: https://bugs.openjdk.java.net/browse/JDK-8214158 > > Michael Paus has updated the pull request incrementally with one additional > commit since the last revision: >